throw LogicException when compiling a route with _fragment as a path parameter

rodnaph · rodnaph · commit 049f0c6680b7 · 2015-09-14T10:10:08.000+01:00
diff --git a/src/Symfony/Component/Routing/RouteCompiler.php b/src/Symfony/Component/Routing/RouteCompiler.php
@@ -59,6 +59,13 @@ public static function compile(Route $route)
         $staticPrefix = $result['staticPrefix'];
 
         $pathVariables = $result['variables'];
+
+        foreach ($pathVariables as $pathParam) {
+            if ('_fragment' == $pathParam) {
+                throw new \LogicException(sprintf('Route pattern "%s" cannot contain "_fragment" as a path parameter.', $route->getPath()));
+            }
+        }
+
         $variables = array_merge($variables, $pathVariables);
 
         $tokens = $result['tokens'];
diff --git a/src/Symfony/Component/Routing/Tests/RouteCompilerTest.php b/src/Symfony/Component/Routing/Tests/RouteCompilerTest.php
@@ -161,6 +161,16 @@ public function testRouteWithSameVariableTwice()
         $compiled = $route->compile();
     }
 
+    /**
+     * @expectedException \LogicException
+     */
+    public function testRouteWithFragmentAsPathParameter()
+    {
+        $route = new Route('/{_fragment}');
+
+        $compiled = $route->compile();
+    }
+
     /**
      * @dataProvider getNumericVariableNames
      * @expectedException \DomainException
