feature #58258 [Process] Add Laravel Herd php detection path (mpociot)

nicolas-grekas · nicolas-grekas · commit 0487a0824d93 · 2024-09-16T16:33:39.000+02:00
This PR was submitted for the 7.1 branch but it was squashed and merged into the 7.2 branch instead. Discussion ---------- [Process] Add Laravel Herd php detection path | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? |yes | Deprecations? |no | Issues | – | License | MIT As of right now, using the `PhpExecutableFinder` in combination with Laravel Herd, results in an empty string, which is what this PR fixes. As the PhpExecutableFinder is already aware of XAMPP, it might be a good idea to also add support for Laravel Herd, which is widely used - not only in the Laravel ecosystem. Laravel Herd uses statically compiled PHP binaries, which is why the `PHP_BINDIR` folder always points to `/bin` instead of a user-specific folder. As Laravel Herd adds a `HERD_HOME` environment variable, we can check for the existence of this variable and then add the bin subdirectory to the list of directories to search. I couldn't find any tests for XAMPP, which is why I haven't included any for this addition. Commits ------- 93ca4e9 [Process] Add Laravel Herd php detection path
diff --git a/src/Symfony/Component/Process/PhpExecutableFinder.php b/src/Symfony/Component/Process/PhpExecutableFinder.php
@@ -86,6 +86,10 @@ public function find(bool $includeArgs = true): string|false
             $dirs[] = 'C:\xampp\php\\';
         }
 
+        if ($herdPath = getenv('HERD_HOME')) {
+            $dirs[] = $herdPath.\DIRECTORY_SEPARATOR.'bin';
+        }
+
         return $this->executableFinder->find('php', false, $dirs);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -86,6 +86,10 @@ public function find(bool $includeArgs = true): string\|false`
`86`	`86`	`$dirs[] = 'C:\xampp\php\\';`
`87`	`87`	`}`
`88`	`88`
	`89`	`+ if ($herdPath = getenv('HERD_HOME')) {`
	`90`	`+ $dirs[] = $herdPath.\DIRECTORY_SEPARATOR.'bin';`
	`91`	`+ }`
	`92`	`+`
`89`	`93`	`return $this->executableFinder->find('php', false, $dirs);`
`90`	`94`	`}`
`91`	`95`