minor #39694 [PropertyAccess] remove unneeded sprintf() call (xabbuh)

derrabus · derrabus · commit 04671ee726b0 · 2021-01-03T13:23:32.000+01:00
This PR was merged into the 4.4 branch. Discussion ---------- [PropertyAccess] remove unneeded sprintf() call | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | Commits ------- a8252a4 remove unneeded sprintf() call
diff --git a/src/Symfony/Component/PropertyAccess/PropertyAccessor.php b/src/Symfony/Component/PropertyAccess/PropertyAccessor.php
@@ -398,7 +398,7 @@ private function readProperty(array $zval, string $property, bool $ignoreInvalid
                     if (__FILE__ === $trace['file']
                         && $access[self::ACCESS_NAME] === $trace['function']
                         && $object instanceof $trace['class']
-                        && preg_match((sprintf('/Return value (?:of .*::\w+\(\) )?must be of (?:the )?type (\w+), null returned$/')), $e->getMessage(), $matches)
+                        && preg_match('/Return value (?:of .*::\w+\(\) )?must be of (?:the )?type (\w+), null returned$/', $e->getMessage(), $matches)
                     ) {
                         throw new AccessException(sprintf('The method "%s::%s()" returned "null", but expected type "%3$s". Did you forget to initialize a property or to make the return type nullable using "?%3$s"?', false === strpos(\get_class($object), "@anonymous\0") ? \get_class($object) : (get_parent_class($object) ?: 'class').'@anonymous', $access[self::ACCESS_NAME], $matches[1]), 0, $e);
                     }

Original file line number	Diff line number	Diff line change
`@@ -398,7 +398,7 @@ private function readProperty(array $zval, string $property, bool $ignoreInvalid`
`398`	`398`	`if (__FILE__ === $trace['file']`
`399`	`399`	`&& $access[self::ACCESS_NAME] === $trace['function']`
`400`	`400`	`&& $object instanceof $trace['class']`
`401`		`- && preg_match((sprintf('/Return value (?:of .*::\w+\(\) )?must be of (?:the )?type (\w+), null returned$/')), $e->getMessage(), $matches)`
	`401`	`+ && preg_match('/Return value (?:of .*::\w+\(\) )?must be of (?:the )?type (\w+), null returned$/', $e->getMessage(), $matches)`
`402`	`402`	`) {`
`403`	`403`	`throw new AccessException(sprintf('The method "%s::%s()" returned "null", but expected type "%3$s". Did you forget to initialize a property or to make the return type nullable using "?%3$s"?', false === strpos(\get_class($object), "@anonymous\0") ? \get_class($object) : (get_parent_class($object) ?: 'class').'@anonymous', $access[self::ACCESS_NAME], $matches[1]), 0, $e);`
`404`	`404`	`}`