8000 Update code to fix performance issues · symfony/symfony@03fc648 · GitHub
[go: up one dir, main page]
Skip to content

Commit 03fc648

Browse files
javiereguiluzjaviereguiluz
committed
Update code to fix performance issues
1 parent 5cec15d commit 03fc648

File tree

2 files changed

+9
-42
lines changed

2 files changed

+9
-42
lines changed

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/base_js.html.twig

Lines changed: 4 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -11,49 +11,11 @@
1111
1212
class SymfonyProfiler {
1313
constructor() {
14-
this.#reorderMainMenuItems();
1514
this.#createTabs();
16-
17-
setTimeout(() => {
18-
this.#createTableSearchFields();
19-
this.#createToggles();
20-
this.#createCopyToClipboard();
21-
this.#convertDateTimesToUserTimezone();
22-
}, 0);
23-
}
24-
25-
#reorderMainMenuItems() {
26-
/* reorder the main menu items to always display first the non-disabled items */
27-
const mainMenuElement = document.querySelector('#menu-profiler');
28-
const mainMenuItems = mainMenuElement.querySelectorAll('li');
29-
const firstDisabledMenuItem = mainMenuElement.querySelector('li a > span.disabled')?.parentNode?.parentNode;
30-
if (!firstDisabledMenuItem) {
31-
return;
32-
}
33-
mainMenuItems.forEach(menuItem => {
34-
const isDisabled = menuItem.querySelector('a > span.disabled');
35-
if (!isDisabled) {
36-
mainMenuElement.insertBefore(menuItem, firstDisabledMenuItem);
37-
}
38-
});
39-
}
40-
41-
#reorderMainMenuItems() {
42-
/* reorder the main menu items to always display first the non-disabled items */
43-
const mainMenuElement = document.querySelector('#menu-profiler');
44-
const firstDisabledMenuItem = mainMenuElement.querySelector('li a > span.disabled')?.parentNode?.parentNode;
45-
46-
if (!firstDisabledMenuItem) {
47-
return;
48-
}
49-
50-
const mainMenuItems = mainMenuElement.querySelectorAll('li');
51-
mainMenuItems.forEach(menuItem => {
52-
const isDisabled = null !== menuItem.querySelector('a > span.disabled');
53-
if (!isDisabled) {
54-
mainMenuElement.insertBefore(menuItem, firstDisabledMenuItem);
55-
}
56-
});
15+
this.#createTableSearchFields();
16+
this.#createToggles();
17+
this.#createCopyToClipboard();
18+
this.#convertDateTimesToUserTimezone();
5719
}
5820
5921
#createTabs() {

‎src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/profiler.css.twig

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1499,11 +1499,16 @@ tr.status-warning td {
14991499
list-style-type: none;
15001500
margin: 0;
15011501
padding: 7px;
1502+
display: flex;
1503+
flex-direction: column;
15021504
}
15031505
#menu-profiler li {
15041506
margin-bottom: 0;
15051507
position: relative;
15061508
}
1509+
#menu-profiler li:has(span.disabled) {
1510+
order: 1;
1511+
}
15071512
#menu-profiler li + li {
15081513
margin-top: 4px;
15091514
}

0 commit comments

Comments
 (0)
0