bug #9237 [FrameworkBundle] assets:install command should mirror .dotfiles (.htaccess) (FineWolf)

fabpot · fabpot · commit 0375dc8f9f37 · 2013-10-09T23:05:14.000+02:00
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #9237). Discussion ---------- [FrameworkBundle] assets:install command should mirror .dotfiles (.htaccess) | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - The `assets:install` command currently ignores all *.dotfiles* when mirroring the `Resources\public` folders of bundles. This can lead to issues when *.htaccess* files are required for some public assets (ie.: CORS headers for font files to be served via Cloudfront). Since the assets being installed are clearly in a folder called `public`, we can safely assume that those files are in fact supposed to be accessible and copy them over with the normal files. Commits ------- 9c884a0 [FrameworkBundle] assets:install command should mirror .dotfiles (.htaccess)
diff --git a/src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php b/src/Symfony/Bundle/FrameworkBundle/Command/AssetsInstallCommand.php
@@ -103,7 +103,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 } else {
                     $filesystem->mkdir($targetDir, 0777);
                     // We use a custom iterator to ignore VCS files
-                    $filesystem->mirror($originDir, $targetDir, Finder::create()->in($originDir));
+                    $filesystem->mirror($originDir, $targetDir, Finder::create()->ignoreDotFiles(false)->in($originDir));
                 }
             }
         }

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ protected function execute(InputInterface $input, OutputInterface $output)`
`103`	`103`	`} else {`
`104`	`104`	`$filesystem->mkdir($targetDir, 0777);`
`105`	`105`	`// We use a custom iterator to ignore VCS files`
`106`		`- $filesystem->mirror($originDir, $targetDir, Finder::create()->in($originDir));`
	`106`	`+ $filesystem->mirror($originDir, $targetDir, Finder::create()->ignoreDotFiles(false)->in($originDir));`
`107`	`107`	`}`
`108`	`108`	`}`
`109`	`109`	`}`