8000 deprecate using invalid names for buttons · symfony/symfony@0328857 · GitHub
[go: up one dir, main page]
Skip to content

Commit 0328857

Browse files
xabbuhxabbuh
committed
deprecate using invalid names for buttons
1 parent 5aa0967 commit 0328857

File tree

5 files changed

+38
-1
lines changed

5 files changed

+38
-1
lines changed

‎UPGRADE-4.3.md‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,15 @@ Config
1313

1414
* Deprecated using environment variables with `cannotBeEmpty()` if the value is validated with `validate()`
1515

16+
Form
17+
----
18+
19+
* Using names for buttons that do not start with a letter, a digit, or an underscore is deprecated and will lead to an
20+
exception in 5.0.
21+
22+
* Using names for buttons that do not contain only letters, digits, underscores, hyphens, and colons is deprecated and
23+
will lead to an exception in 5.0.
24+
1625
FrameworkBundle
1726
---------------
1827

‎UPGRADE-5.0.md‎

Lines changed: 5 additions & 0 deletions
8000
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,11 @@ Finder
7676
Form
7777
----
7878

79+
* Using names for buttons that do not start with a letter, a digit, or an underscore leads to an exception.
80+
81+
* Using names for buttons that do not contain only letters, digits, underscores, hyphens, and colons leads to an
82+
exception.
83+
7984
* The `getExtendedType()` method was removed from the `FormTypeExtensionInterface`. It is replaced by the the static
8085
`getExtendedTypes()` method which must return an iterable of extended types.
8186

‎src/Symfony/Component/Form/ButtonBuilder.php‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,18 @@ public function __construct(?string $name, array $options = [])
6363

6464
$this->name = $name;
6565
$this->options = $options;
66+
67+
if (\preg_match('/^([^a-z0-9_].*)?(.*[^a-zA-Z0-9_\-:].*)?$/D', $name, $matches)) {
68+
if (isset($matches[1])) {
69+
@trigger_error(sprintf('Using names for buttons that do not start with a letter, a digit, or an underscore is deprecated since Symfony 4.3 and will throw an exception in 5.0 ("%s" given).', $name), E_USER_DEPRECATED);
70+
}
71+
if (isset($matches[2])) {
72+
@trigger_error(sprintf('Using names for buttons that do not contain only letters, digits, underscores ("_"), hyphens ("-") and colons (":") ("%s" given) is deprecated since Symfony 4.3 and will throw an exception in 5.0.', $name), E_USER_DEPRECATED);
73+
}
74+
}
75+
76+
// to be added in 5.0
77+
// FormConfigBuilder::validateName($name);
6678
}
6779

6880
/**

‎src/Symfony/Component/Form/CHANGELOG.md‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,10 @@ CHANGELOG
44
4.3.0
55
-----
66

7+
* Using names for buttons that do not start with a letter, a digit, or an underscore is deprecated and will lead to an
8+
exception in 5.0.
9+
* Using names for buttons that do not contain only letters, digits, underscores, hyphens, and colons is deprecated and
10+
will lead to an exception in 5.0.
711
* added `block_prefix` option to `BaseType`.
812

913
4.2.0

‎src/Symfony/Component/Form/Tests/ButtonBuilderTest.php‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,6 @@ public function getValidNames()
2828
['foo'],
2929
['0'],
3030
[0],
31-
['button[]'],
3231
];
3332
}
3433

@@ -40,6 +39,14 @@ public function testValidNames($name)
4039
$this->assertInstanceOf('\Symfony\Component\Form\ButtonBuilder', new ButtonBuilder($name));
4140
}
4241

42+
/**
43+
* @group legacy
44+
*/
45+
public function testNameContainingIllegalCharacters()
46+
{
47+
$this->assertInstanceOf('\Symfony\Component\Form\ButtonBuilder', new ButtonBuilder('button[]'));
48+
}
49+
4350
public function getInvalidNames()
4451
{
4552
return [

0 commit comments

Comments
 (0)
0