review feedback

dmaicher · dmaicher · commit 02c90ef27352 · 2017-10-18T23:06:17.000+02:00
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -319,7 +319,7 @@ public function load(array $configs, ContainerBuilder $container)
         }
 
         if ($config['reset_services_on_terminate']) {
-            $container->register(ServiceResetListener::class)->addTag('kernel.event_subscriber');
+            $container->register(ServiceResetListener::class)->addTag('kernel.event_subscriber')->setPublic(false);
         }
 
         $this->addAnnotatedClassesToCompile(array(
diff --git a/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php b/src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
@@ -1008,7 +1008,10 @@ public function testDoesNotAddServiceResetListenerDefWhenOptionSetToFalse()
     public function testAddsServiceResetListenerDefWhenOptionSetToTrue()
     {
         $container = $this->createContainerFromFile('reset_services');
-        $this->assertEquals((new Definition(ServiceResetListener::class))->addTag('kernel.event_subscriber'), $container->getDefinition(ServiceResetListener::class));
+        $this->assertEquals(
+            (new Definition(ServiceResetListener::class))->addTag('kernel.event_subscriber')->setPublic(false),
+            $container->getDefinition(ServiceResetListener::class)
+        );
     }
 
     protected function createContainer(array $data = array())

Original file line number	Diff line number	Diff line change
`@@ -319,7 +319,7 @@ public function load(array $configs, ContainerBuilder $container)`
`319`	`319`	`}`
`320`	`320`
`321`	`321`	`if ($config['reset_services_on_terminate']) {`
`322`		`- $container->register(ServiceResetListener::class)->addTag('kernel.event_subscriber');`
	`322`	`+ $container->register(ServiceResetListener::class)->addTag('kernel.event_subscriber')->setPublic(false);`
`323`	`323`	`}`
`324`	`324`
`325`	`325`	`$this->addAnnotatedClassesToCompile(array(`
Original file line number	Diff line number	Diff line change
`@@ -1008,7 +1008,10 @@ public function testDoesNotAddServiceResetListenerDefWhenOptionSetToFalse()`
`1008`	`1008`	`public function testAddsServiceResetListenerDefWhenOptionSetToTrue()`
`1009`	`1009`	`{`
`1010`	`1010`	`$container = $this->createContainerFromFile('reset_services');`
`1011`		`- $this->assertEquals((new Definition(ServiceResetListener::class))->addTag('kernel.event_subscriber'), $container->getDefinition(ServiceResetListener::class));`
	`1011`	`+ $this->assertEquals(`
	`1012`	`+ (new Definition(ServiceResetListener::class))->addTag('kernel.event_subscriber')->setPublic(false),`
	`1013`	`+ $container->getDefinition(ServiceResetListener::class)`
	`1014`	`+ );`
`1012`	`1015`	`}`
`1013`	`1016`
`1014`	`1017`	`protected function createContainer(array $data = array())`