bug #25606 Updating message to inform the user how to install the component (weaverryan)

nicolas-grekas · nicolas-grekas · commit 02524ee5cd23 · 2017-12-27T11:16:14.000+01:00
This PR was submitted for the 4.0 branch but it was squashed and merged into the 3.4 branch instead (closes #25606). Discussion ---------- Updating message to inform the user how to install the component | Q | A | ------------- | --- | Branch? | 4.0 | Bug fix? | yes-ish | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | n/a Simple: direct the user exactly what to do if they hit this :) Commits ------- 07ac535 Updating message to inform the user how to install the component
diff --git a/src/Symfony/Component/DomCrawler/Crawler.php b/src/Symfony/Component/DomCrawler/Crawler.php
@@ -691,8 +691,8 @@ public function filterXPath($xpath)
      */
     public function filter($selector)
     {
-        if (!class_exists('Symfony\\Component\\CssSelector\\CssSelectorConverter')) {
-            throw new \RuntimeException('Unable to filter with a CSS selector as the Symfony CssSelector 2.8+ is not installed (you can use filterXPath instead).');
+        if (!class_exists(CssSelectorConverter::class)) {
+            throw new \RuntimeException('To filter with a CSS selector, install the CssSelector component ("composer require symfony/css-selector"). Or use filterXpath instead.');
         }
 
         $converter = new CssSelectorConverter($this->isHtml);

Original file line number	Diff line number	Diff line change
`@@ -691,8 +691,8 @@ public function filterXPath($xpath)`
`691`	`691`	`*/`
`692`	`692`	`public function filter($selector)`
`693`	`693`	`{`
`694`		`- if (!class_exists('Symfony\\Component\\CssSelector\\CssSelectorConverter')) {`
`695`		`- throw new \RuntimeException('Unable to filter with a CSS selector as the Symfony CssSelector 2.8+ is not installed (you can use filterXPath instead).');`
	`694`	`+ if (!class_exists(CssSelectorConverter::class)) {`
	`695`	`+ throw new \RuntimeException('To filter with a CSS selector, install the CssSelector component ("composer require symfony/css-selector"). Or use filterXpath instead.');`
`696`	`696`	`}`
`697`	`697`
`698`	`698`	`$converter = new CssSelectorConverter($this->isHtml);`