[HttpCache] fixed if-modified-since header default to an empty string if the last-modified header was not set

akalineskou · akalineskou · commit 020aae3300de · 2019-10-17T20:20:19.000+03:00
The problem I had with this was that the psr http factory would create the request, and would throw an exception because the null value isn't an allowed header value https://github.com/symfony/psr-http-message-bridge/blob/8564bf76630423ced21bbbee189947b90677dcde/Factory/PsrHttpFactory.php#L72 https://github.com/Nyholm/psr7/blob/55ff6b76573f5b242554c9775792bd59fb52e11c/src/MessageTrait.php#L180
diff --git a/src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php b/src/Symfony/Component/HttpKernel/HttpCache/HttpCache.php
@@ -352,7 +352,7 @@ protected function validate(Request $request, Response $entry, $catch = false)
         }
 
         // add our cached last-modified validator
-        $subRequest->headers->set('if_modified_since', $entry->headers->get('Last-Modified'));
+        $subRequest->headers->set('if_modified_since', $entry->headers->get('Last-Modified', ''));
 
         // Add our cached etag validator to the environment.
         // We keep the etags from the client to handle the case when the client

Original file line number	Diff line number	Diff line change
`@@ -352,7 +352,7 @@ protected function validate(Request $request, Response $entry, $catch = false)`
`352`	`352`	`}`
`353`	`353`
`354`	`354`	`// add our cached last-modified validator`
`355`		`- $subRequest->headers->set('if_modified_since', $entry->headers->get('Last-Modified'));`
	`355`	`+ $subRequest->headers->set('if_modified_since', $entry->headers->get('Last-Modified', ''));`
`356`	`356`
`357`	`357`	`// Add our cached etag validator to the environment.`
`358`	`358`	`// We keep the etags from the client to handle the case when the client`