[Form] fixed Date\TimeType marked as invalid on request with single_text and zero seconds (LuisDeimos)

LuisDeimos · LuisDeimos · commit 006f2368f66c · 2016-10-27T02:38:52.000-05:00
diff --git a/src/Symfony/Component/Form/Extension/Core/Type/TimeType.php b/src/Symfony/Component/Form/Extension/Core/Type/TimeType.php
@@ -52,15 +52,14 @@ public function buildForm(FormBuilderInterface $builder, array $options)
         if ('single_text' === $options['widget']) {
             $builder->addViewTransformer(new DateTimeToStringTransformer($options['model_timezone'], $options['view_timezone'], $format));
 
-            // handle seconds ignored by user's browser when with_seconds enabled and seconds is 00
+            // handle seconds ignored by user's browser when with_seconds enabled
+            // https://codereview.chromium.org/450533009/
             if ($options['with_seconds']) {
                 $builder->addEventListener(FormEvents::PRE_SUBMIT, function (FormEvent $e) {
-                    if ($data = $e->getData()) {
-                        if (preg_match('/^\d{2}:\d{2}$/', $data)) {
-                            $e->setData($data.':00');
-                        }
+                    $data = $e->getData();
+                    if ($data && preg_match('/^\d{2}:\d{2}$/', $data)) {
+                        $e->setData($data.':00');
                     }
-
                 });
             }
         } else {
diff --git a/src/Symfony/Component/Form/Tests/Extension/Core/Type/TimeTypeTest.php b/src/Symfony/Component/Form/Tests/Extension/Core/Type/TimeTypeTest.php
@@ -221,6 +221,22 @@ public function testSubmitStringSingleTextWithoutMinutes()
         $this->assertEquals('03', $form->getViewData());
     }
 
+    public function testSubmitWithSecondsAndBrowserOmissionSeconds()
+    {
+        $form = $this->factory->create('time', null, array(
+            'model_timezone' => 'UTC',
+            'view_timezone' => 'UTC',
+            'input' => 'string',
+            'widget' => 'single_text',
+            'with_seconds' => true,
+        ));
+
+        $form->submit('03:04');
+
+        $this->assertEquals('03:04:00', $form->getData());
+        $this->assertEquals('03:04:00', $form->getViewData());
+    }
+
     public function testSetDataWithoutMinutes()
     {
         $form = $this->factory->create('time', null, array(
