8000 applied code review suggestions · symfony/symfony@000a398 · GitHub
[go: up one dir, main page]
Skip to content

Commit 000a398

Browse files
kbondkbond
committed
applied code review suggestions
1 parent 6cdc5e2 commit 000a398

File tree

5 files changed

+6
-7
lines changed

5 files changed

+6
-7
lines changed

‎src/Symfony/Component/Process/Messenger/RunProcessFailedException.php renamed to ‎src/Symfony/Component/Process/Exception/RunProcessFailedException.php

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,9 @@
99
* file that was distributed with this source code.
1010
*/
1111

12-
namespace Symfony\Component\Process\Messenger;
12+
namespace Symfony\Component\Process\Exception;
1313

14-
use Symfony\Component\Process\Exception\ProcessFailedException;
15-
use Symfony\Component\Process\Exception\RuntimeException;
14+
use Symfony\Component\Process\Messenger\RunProcessContext;
1615

1716
/**
1817
* @author Kevin Bond <kevinbond@gmail.com>

‎src/Symfony/Component/Process/Messenger/RunProcessContext.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,5 +30,4 @@ public function __construct(RunProcessMessage $message, Process $process)
3030
$this->output = $process->isOutputDisabled() ? null : $process->getOutput();
3131
$this->errorOutput = $process->isOutputDisabled() ? null : $process->getErrorOutput();
3232
}
33-
3433
}

‎src/Symfony/Component/Process/Messenger/RunProcessMessage.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public function __construct(
2121
public readonly ?string $cwd = null,
2222
public readonly ?array $env = null,
2323
public readonly mixed $input = null,
24-
public readonly ?float $timeout = 60,
24+
public readonly ?float $timeout = 60.0,
2525
) {
2626
}
2727

‎src/Symfony/Component/Process/Messenger/RunProcessMessageHandler.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@
1212
namespace Symfony\Component\Process\Messenger;
1313

1414
use Symfony\Component\Process\Exception\ProcessFailedException;
15+
use Symfony\Component\Process\Exception\RunProcessFailedException;
1516
use Symfony\Component\Process\Process;
1617

1718
/**

‎src/Symfony/Component/Process/Tests/Messenger/RunProcessMessageHandlerTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
namespace Symfony\Component\Process\Tests\Messenger;
1313

1414
use PHPUnit\Framework\TestCase;
15-
use Symfony\Component\Process\Messenger\RunProcessFailedException;
15+
use Symfony\Component\Process\Exception\RunProcessFailedException;
1616
use Symfony\Component\Process\Messenger\RunProcessMessage;
1717
use Symfony\Component\Process\Messenger\RunProcessMessageHandler;
1818

@@ -31,7 +31,7 @@ public function testRunFailedProcess()
3131
{
3232
try {
3333
(new RunProcessMessageHandler())(new RunProcessMessage('invalid'));
34-
} catch (RunProcessFailedException $e) {
34+
} catch (\Symfony\Component\Process\Exception\RunProcessFailedException $e) {
3535
$this->assertSame('invalid', $e->context->command);
3636
$this->assertSame(127, $e->context->exitCode);
3737

0 commit comments

Comments
 (0)
0