Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
- 6 commits
- 13 files changed
- 2 contributors
Commits on Jul 13, 2022
Commits on Nov 23, 2022
Commits on Jan 10, 2023
-
minor #76 Fix README: registering lazy controllers in bootstrap.js (j…
…msche) This PR was merged into the main branch. Discussion ---------- Fix README: registering lazy controllers in bootstrap.js Commits ------- 869519d Fix README: registering lazy controllers in bootstrap.js
Commits on Mar 20, 2023
-
bug #81 [Bug] Removing unnecessary Promise in object of controllers t…
…o be loaded (weaverryan) This PR was squashed before being merged into the main branch. Discussion ---------- [Bug] Removing unnecessary Promise in object of controllers to be loaded Hi! Subtle change. Previously, the webpack loader parsed `controllers.json` (which eventually becomes the `symfonyControllers` variable in `index.ts`) into something that exported an object where each key was a promise - something like: ```js export default { 'symfony--ux-autocomplete--autocomplete': import(/* webpackMode: \"eager\" */ '`@symfony`/ux-autocomplete/dist/controller.js') } ``` Then, in `startStimulusApp()`, we called used `.then()` to wait for that promise to resolve then registered its resolved value: ```js symfonyControllers[controllerName].then((module) => { application.register(controllerName, module.default); }); ``` This is totally unnecessary and a relic of how this library was originally built. It also causes the UX controllers to be registered *late*. It's barely noticeable, but in practice, instead of the UX controllers being registered BEFORE the DOM is ready, they are registered after. This actually causes a problem with a new feature from LiveComponents. The new parsed version of `controllers.json` from the loader looks much simpler: ```diff + import controller_0 from '`@symfony`/ux-autocomplete/dist/controller.js'; export default { - 'symfony--ux-autocomplete--autocomplete': import(/* webpackMode: \"eager\" */ '`@symfony`/ux-autocomplete/dist/controller.js') + 'symfony--ux-autocomplete--autocomplete': controller_0, } ``` (I don't show it here, but lazy controllers have a similar simplification). In short: it's a bug fix & an easy win. Controllers will load slightly earlier as a result. Thanks! Commits ------- 0d77e41 [Bug] Removing unnecessary Promise in object of controllers to be loaded -
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v3.2.1...v3.2.2