8000 feature #98 [BREAKING] Drop Node.js 14 and 16 support (Kocal) · symfony/stimulus-bridge@2e28423 · GitHub
[go: up one dir, main page]
Skip to content

Commit 2e28423

Browse files
KocalKocal
committed
feature #98 [BREAKING] Drop Node.js 14 and 16 support (Kocal)
This PR was merged into the main branch. Discussion ---------- [BREAKING] Drop Node.js 14 and 16 support Following #94, let's continue to drop old unmaintained [Node.js versions](https://nodejs.org/en/about/previous-releases): <img width="757" alt="image" src="https://github.com/user-attachments/assets/1730bb19-02ce-4651-89b8-7acf84dfb720" /> Commits ------- 68da84e [BREAKING] Drop Node.js 14 and 16 support
2 parents 4ac522d + 68da84e commit 2e28423

File tree

2 files changed

+7
-4
lines changed

2 files changed

+7
-4
lines changed

‎.github/workflows/test.yaml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
name: Test
22

3+
env:
4+
NODE_VERSION_LOWEST_SUPPORTED: 18
5+
36
on:
47
pull_request:
58
push:
@@ -15,7 +18,7 @@ jobs:
1518
- name: Install Node
1619
uses: actions/setup-node@v4
1720
with:
18-
node-version: 14 # lowest supported version
21+
node-version: ${{ env.NODE_VERSION_LOWEST_SUPPORTED }} # lowest supported version
1922

2023
- name: Install Yarn Dependencies
2124
run: yarn install
@@ -32,7 +35,7 @@ jobs:
3235
- name: Install Node
3336
uses: actions/setup-node@v4
3437
with:
35-
node-version: 14 # lowest supported version
38+
node-version: ${{ env.NODE_VERSION_LOWEST_SUPPORTED }} # lowest supported version
3639

3740
- run: yarn install && yarn build
3841

@@ -52,7 +55,7 @@ jobs:
5255
strategy:
5356
fail-fast: false
5457
matrix:
55-
node-versions: [ '14', '16', '18', '20', '22', '23' ]
58+
node-versions: [ '18', '20', '22', '23' ]
5659
steps:
5760
- name: Checkout
5861
uses: actions/checkout@v4

‎package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "MIT",
88
"author": "Titouan Galopin <galopintitouan@gmail.com>",
99
"engines": {
10-
"node": "^14.15.0 || ^16.10.0 || ^18.12.0 || ^20.0.0 || >=22.0"
10+
"node": "^18.12.0 || ^20.0.0 || >=22.0"
1111
},
1212
"scripts": {
1313
"build": "yarn rollup -c",

0 commit comments

Comments
 (0)
0