Removed dead code and various cleaning

saro0h · saro0h · commit d56e9ed93dc8 · 2015-01-21T21:14:55.000+01:00
diff --git a/Dbal/MutableAclProvider.php b/Dbal/MutableAclProvider.php
@@ -863,7 +863,6 @@ private function updateNewAceProperty($name, array $changes)
 
         $sids = new \SplObjectStorage();
         $classIds = new \SplObjectStorage();
-        $currentIds = array();
         for ($i = 0, $c = count($new); $i<$c; $i++) {
             $ace = $new[$i];
 
@@ -890,8 +889,6 @@ private function updateNewAceProperty($name, array $changes)
                 $aceIdProperty = new \ReflectionProperty($ace, 'id');
                 $aceIdProperty->setAccessible(true);
                 $aceIdProperty->setValue($ace, intval($aceId));
-            } else {
-                $currentIds[$ace->getId()] = true;
             }
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -863,7 +863,6 @@ private function updateNewAceProperty($name, array $changes)`
`863`	`863`
`864`	`864`	`$sids = new \SplObjectStorage();`
`865`	`865`	`$classIds = new \SplObjectStorage();`
`866`		`- $currentIds = array();`
`867`	`866`	`for ($i = 0, $c = count($new); $i<$c; $i++) {`
`868`	`867`	`$ace = $new[$i];`
`869`	`868`
`@@ -890,8 +889,6 @@ private function updateNewAceProperty($name, array $changes)`
`890`	`889`	`$aceIdProperty = new \ReflectionProperty($ace, 'id');`
`891`	`890`	`$aceIdProperty->setAccessible(true);`
`892`	`891`	`$aceIdProperty->setValue($ace, intval($aceId));`
`893`		`- } else {`
`894`		`- $currentIds[$ace->getId()] = true;`
`895`	`892`	`}`
`896`	`893`	`}`
`897`	`894`	`}`