Merge branch '7.1' into 7.2

xabbuh · xabbuh · commit 07f2b5cbf2ea · 2025-01-07T13:55:42.000+01:00
* 7.1:
  Remove comment about AppVeyor in `phpunit`
  [Webhook][RemoteEvent] fix SendgridPayloadConverter category support
  Update old Appveyor skip conditions
  sync the Dutch translation file with changes from the 7.2 branch
  [Yaml] fix inline notation with inline comment
  fix(property-info): make sure that SerializerExtractor returns null for invalid class metadata
  [RemoteEvent][Webhook] fix SendgridRequestParser &amp; SendgridPayloadConverter in case of missing sg_message_id
  fix_50486 - memory leak
diff --git a/Extractor/SerializerExtractor.php b/Extractor/SerializerExtractor.php
@@ -34,7 +34,7 @@ public function getProperties(string $class, array $context = []): ?array
             return null;
         }
 
-        if (!$this->classMetadataFactory->getMetadataFor($class)) {
+        if (!$this->classMetadataFactory->hasMetadataFor($class)) {
             return null;
         }
 
diff --git a/Tests/Extractor/SerializerExtractorTest.php b/Tests/Extractor/SerializerExtractorTest.php
@@ -49,4 +49,9 @@ public function testGetPropertiesWithAnyGroup()
     {
         $this->assertSame(['analyses', 'feet'], $this->extractor->getProperties(AdderRemoverDummy::class, ['serializer_groups' => null]));
     }
+
+    public function testGetPropertiesWithNonExistentClassReturnsNull()
+    {
+        $this->assertSame(null, $this->extractor->getProperties('NonExistent'));
+    }
 }

Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function getProperties(string $class, array $context = []): ?array`
`34`	`34`	`return null;`
`35`	`35`	`}`
`36`	`36`
`37`		`- if (!$this->classMetadataFactory->getMetadataFor($class)) {`
	`37`	`+ if (!$this->classMetadataFactory->hasMetadataFor($class)) {`
`38`	`38`	`return null;`
`39`	`39`	`}`
`40`	`40`
Original file line number	Diff line number	Diff line change
`@@ -49,4 +49,9 @@ public function testGetPropertiesWithAnyGroup()`
`49`	`49`	`{`
`50`	`50`	`$this->assertSame(['analyses', 'feet'], $this->extractor->getProperties(AdderRemoverDummy::class, ['serializer_groups' => null]));`
`51`	`51`	`}`
	`52`	`+`
	`53`	`+ public function testGetPropertiesWithNonExistentClassReturnsNull()`
	`54`	`+ {`
	`55`	`+ $this->assertSame(null, $this->extractor->getProperties('NonExistent'));`
	`56`	`+ }`
`52`	`57`	`}`