feature #23262 Add scalar typehints/return types (chalasr, xabbuh)

fabpot · fabpot · commit 19a954cb4b78 · 2017-09-03T09:17:01.000-07:00
This PR was merged into the 4.0-dev branch. Discussion ---------- Add scalar typehints/return types | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no (final, already breaks if doc not respected) | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#23242 (comment) | License | MIT | Doc PR | n/a Commits ------- 7b1715b078 [Yaml] use scalar type hints where possible 6ce70e4bf9 Add scalar typehints/return types on final/internal/private code
diff --git a/PropertyAccess.php b/PropertyAccess.php
@@ -23,17 +23,12 @@ final class PropertyAccess
      *
      * @return PropertyAccessor
      */
-    public static function createPropertyAccessor()
+    public static function createPropertyAccessor(): PropertyAccessor
     {
         return self::createPropertyAccessorBuilder()->getPropertyAccessor();
     }
 
-    /**
-     * Creates a property accessor builder.
-     *
-     * @return PropertyAccessorBuilder
-     */
-    public static function createPropertyAccessorBuilder()
+    public static function createPropertyAccessorBuilder(): PropertyAccessorBuilder
     {
         return new PropertyAccessorBuilder();
     }

Original file line number	Diff line number	Diff line change
`@@ -23,17 +23,12 @@ final class PropertyAccess`
`23`	`23`	`*`
`24`	`24`	`* @return PropertyAccessor`
`25`	`25`	`*/`
`26`		`- public static function createPropertyAccessor()`
	`26`	`+ public static function createPropertyAccessor(): PropertyAccessor`
`27`	`27`	`{`
`28`	`28`	`return self::createPropertyAccessorBuilder()->getPropertyAccessor();`
`29`	`29`	`}`
`30`	`30`
`31`		`- /**`
`32`		`- * Creates a property accessor builder.`
`33`		`- *`
`34`		`- * @return PropertyAccessorBuilder`
`35`		`- */`
`36`		`- public static function createPropertyAccessorBuilder()`
	`31`	`+ public static function createPropertyAccessorBuilder(): PropertyAccessorBuilder`
`37`	`32`	`{`
`38`	`33`	`return new PropertyAccessorBuilder();`
`39`	`34`	`}`