[Process] Improve test cleanup by unlinking in a finally block

alexandre-daubois · alexandre-daubois · commit b61fb1c70392 · 2024-11-04T09:44:46.000+01:00
diff --git a/Tests/ExecutableFinderTest.php b/Tests/ExecutableFinderTest.php
@@ -125,18 +125,20 @@ public function testFindBatchExecutableOnWindows()
 
         $target = tempnam(sys_get_temp_dir(), 'example-windows-executable');
 
-        touch($target);
-        touch($target.'.BAT');
-
-        $this->assertFalse(is_executable($target));
+        try {
+            touch($target);
+            touch($target.'.BAT');
 
-        putenv('PATH='.sys_get_temp_dir());
+            $this->assertFalse(is_executable($target));
 
-        $finder = new ExecutableFinder();
-        $result = $finder->find(basename($target), false);
+            putenv('PATH='.sys_get_temp_dir());
 
-        unlink($target);
-        unlink($target.'.BAT');
+            $finder = new ExecutableFinder();
+            $result = $finder->find(basename($target), false);
+        } finally {
+            unlink($target);
+            unlink($target.'.BAT');
+        }
 
         $this->assertSamePath($target.'.BAT', $result);
     }
@@ -148,15 +150,17 @@ public function testEmptyDirInPath()
     {
         putenv(sprintf('PATH=%s:', \dirname(\PHP_BINARY)));
 
-        touch('executable');
-        chmod('executable', 0700);
-
-        $finder = new ExecutableFinder();
-        $result = $finder->find('executable');
+        try {
+            touch('executable');
+            chmod('executable', 0700);
 
-        $this->assertSame('./executable', $result);
+            $finder = new ExecutableFinder();
+            $result = $finder->find('executable');
 
-        unlink('executable');
+            $this->assertSame('./executable', $result);
+        } finally {
+            unlink('executable');
+        }
     }
 
     private function assertSamePath($expected, $tested)
