feature #279 Flush loggers on kernel.reset (dnna)

lyrixx · lyrixx · commit 668479497b44 · 2019-05-16T12:21:09.000+02:00
This PR was squashed before being merged into the 3.x-dev branch (closes #279). Discussion ---------- Flush loggers on kernel.reset Fixes php-pm/php-pm-httpkernel#134 and php-pm/php-pm-httpkernel#62 When using [PHP-PM](https://github.com/php-pm/php-pm) the worker does not die at the end of the request, so the shutdown functions registered by monolog are never triggered (so for example `BufferHandler` never flushes). This PR partially fixes the problem by flushing the loggers containing a `flush` function at the end of each request. I did not use the `close` function (mentioned in Seldaek/monolog#1053) because some loggers use sockets or other connections that would be closed in this case and not be reusable in the next request. I'm not sure if this is the best solution to this problem, happy to discuss alternatives if there is a better way. Commits ------- 366f692 Flush loggers on kernel.reset
diff --git a/DependencyInjection/MonologExtension.php b/DependencyInjection/MonologExtension.php
@@ -20,6 +20,7 @@
 use Symfony\Component\Config\FileLocator;
 use Symfony\Component\DependencyInjection\Definition;
 use Symfony\Component\DependencyInjection\Reference;
+use Monolog\ResettableInterface;
 
 /**
  * MonologExtension is an extension for the Monolog library.
@@ -153,7 +154,8 @@ private function buildHandler(ContainerBuilder $container, $name, array $handler
             return $handlerId;
         }
 
-        $definition = new Definition($this->getHandlerClassByType($handler['type']));
+        $handlerClass = $this->getHandlerClassByType($handler['type']);
+        $definition = new Definition($handlerClass);
 
         $handler['level'] = $this->levelToMonologConst($handler['level']);
 
@@ -757,6 +759,11 @@ private function buildHandler(ContainerBuilder $container, $name, array $handler
         if (!empty($handler['formatter'])) {
             $definition->addMethodCall('setFormatter', array(new Reference($handler['formatter'])));
         }
+
+        if (!in_array($handlerId, $this->nestedHandlers) && is_subclass_of($handlerClass, ResettableInterface::class)) {
+            $definition->addTag('kernel.reset', array('method' => 'reset'));
+        }
+
         $container->setDefinition($handlerId, $definition);
 
         return $handlerId;
