feature #42050 [Security] Deprecate TokenInterface::isAuthenticated() (chalasr)

derrabus · derrabus · commit 42f7dc62470b · 2021-07-14T18:32:50.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Security] Deprecate `TokenInterface::isAuthenticated()` | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | - | License | MIT | Doc PR | todo From symfony/symfony#41613 (comment) > all unauthenticated token use-cases have been replaced with passports (and the removal of anonymous). This means that if you have a token, it should always be authenticated. Commits ------- 33b8fbdd8a [Security] Deprecate `TokenInterface::isAuthenticated()` and `setAuthenticated()`
diff --git a/Processor/AbstractTokenProcessor.php b/Processor/AbstractTokenProcessor.php
@@ -42,7 +42,7 @@ public function __invoke(array $record): array
 
         if (null !== $token = $this->getToken()) {
             $record['extra'][$this->getKey()] = [
-                'authenticated' => $token->isAuthenticated(),
+                'authenticated' => $token->isAuthenticated(false), // @deprecated since Symfony 5.4, always true in 6.0
                 'roles' => $token->getRoleNames(),
             ];
 
diff --git a/Tests/Processor/TokenProcessorTest.php b/Tests/Processor/TokenProcessorTest.php
@@ -39,7 +39,6 @@ public function testLegacyProcessor()
 
         $this->assertArrayHasKey('token', $record['extra']);
         $this->assertEquals($token->getUsername(), $record['extra']['token']['username']);
-        $this->assertEquals($token->isAuthenticated(), $record['extra']['token']['authenticated']);
         $this->assertEquals(['ROLE_USER'], $record['extra']['token']['roles']);
     }
 
@@ -59,7 +58,6 @@ public function testProcessor()
 
         $this->assertArrayHasKey('token', $record['extra']);
         $this->assertEquals($token->getUserIdentifier(), $record['extra']['token']['user_identifier']);
-        $this->assertEquals($token->isAuthenticated(), $record['extra']['token']['authenticated']);
         $this->assertEquals(['ROLE_USER'], $record['extra']['token']['roles']);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,6 @@ public function testLegacyProcessor()`
`39`	`39`
`40`	`40`	`$this->assertArrayHasKey('token', $record['extra']);`
`41`	`41`	`$this->assertEquals($token->getUsername(), $record['extra']['token']['username']);`
`42`		`- $this->assertEquals($token->isAuthenticated(), $record['extra']['token']['authenticated']);`
`43`	`42`	`$this->assertEquals(['ROLE_USER'], $record['extra']['token']['roles']);`
`44`	`43`	`}`
`45`	`44`
`@@ -59,7 +58,6 @@ public function testProcessor()`
`59`	`58`
`60`	`59`	`$this->assertArrayHasKey('token', $record['extra']);`
`61`	`60`	`$this->assertEquals($token->getUserIdentifier(), $record['extra']['token']['user_identifier']);`
`62`		`- $this->assertEquals($token->isAuthenticated(), $record['extra']['token']['authenticated']);`
`63`	`61`	`$this->assertEquals(['ROLE_USER'], $record['extra']['token']['roles']);`
`64`	`62`	`}`
`65`	`63`	`}`