From 420ae583ded785a776dabe23364d4dcb13f666c5 Mon Sep 17 00:00:00 2001 From: "Jonathan H. Wage" Date: Mon, 21 Apr 2025 11:22:52 -0400 Subject: [PATCH 1/2] Revert "[Messenger] Add call to `gc_collect_cycles()` after each message is handled" This reverts commit b0df65ae9aeb86a650abe9cd4d627c3bade66000. --- Tests/WorkerTest.php | 19 ------------------- Worker.php | 2 -- 2 files changed, 21 deletions(-) diff --git a/Tests/WorkerTest.php b/Tests/WorkerTest.php index cb36ce9..5cf8c38 100644 --- a/Tests/WorkerTest.php +++ b/Tests/WorkerTest.php @@ -584,25 +584,6 @@ public function testFlushBatchOnStop() $this->assertSame($expectedMessages, $handler->processedMessages); } - - public function testGcCollectCyclesIsCalledOnMessageHandle() - { - $apiMessage = new DummyMessage('API'); - - $receiver = new DummyReceiver([[new Envelope($apiMessage)]]); - - $bus = $this->createMock(MessageBusInterface::class); - - $dispatcher = new EventDispatcher(); - $dispatcher->addSubscriber(new StopWorkerOnMessageLimitListener(1)); - - $worker = new Worker(['transport' => $receiver], $bus, $dispatcher); - $worker->run(); - - $gcStatus = gc_status(); - - $this->assertGreaterThan(0, $gcStatus['runs']); - } } class DummyQueueReceiver extends DummyReceiver implements QueueReceiverInterface diff --git a/Worker.php b/Worker.php index e881122..68510c3 100644 --- a/Worker.php +++ b/Worker.php @@ -117,8 +117,6 @@ public function run(array $options = []): void // this should prevent multiple lower priority receivers from // blocking too long before the higher priority are checked if ($envelopeHandled) { - gc_collect_cycles(); - break; } } From f99fbe6a4727ea504eb9ecc9f76e1ed61d2d6f33 Mon Sep 17 00:00:00 2001 From: Fabien Potencier Date: Sun, 27 Apr 2025 15:26:02 +0200 Subject: [PATCH 2/2] Remove unneeded use statements --- Tests/Middleware/DispatchAfterCurrentBusMiddlewareTest.php | 1 - 1 file changed, 1 deletion(-) diff --git a/Tests/Middleware/DispatchAfterCurrentBusMiddlewareTest.php b/Tests/Middleware/DispatchAfterCurrentBusMiddlewareTest.php index 477af7b..2c671cf 100644 --- a/Tests/Middleware/DispatchAfterCurrentBusMiddlewareTest.php +++ b/Tests/Middleware/DispatchAfterCurrentBusMiddlewareTest.php @@ -13,7 +13,6 @@ use PHPUnit\Framework\AssertionFailedError; use PHPUnit\Framework\Constraint\Callback; -use PHPUnit\Framework\MockObject\Stub\ReturnCallback; use PHPUnit\Framework\TestCase; use Symfony\Component\Messenger\Envelope; use Symfony\Component\Messenger\Exception\DelayedMessageHandlingException;