Early return if not entity

maelanleborgne · jrushlow · maelanleborgne · commit b4b97107b1cb · 2024-02-27T16:37:00.000+01:00
Co-authored-by: Jesse Rushlow &lt;40327885+jrushlow@users.noreply.github.com&gt;
diff --git a/src/Security/UserClassBuilder.php b/src/Security/UserClassBuilder.php
@@ -264,14 +264,16 @@ private function addEraseCredentials(ClassSourceManipulator $manipulator): void
 
     private function addUniqueConstraint(ClassSourceManipulator $manipulator, UserClassConfiguration $userClassConfig): void
     {
-        if ($userClassConfig->isEntity()) {
-            $manipulator->addAttributeToClass(
-                'ORM\\UniqueConstraint',
-                [
-                    'name' => 'UNIQ_IDENTIFIER_'.strtoupper(Str::asSnakeCase($userClassConfig->getIdentityPropertyName())),
-                    'fields' => [$userClassConfig->getIdentityPropertyName()],
-                ]
-            );
+        if (!$userClassConfig->isEntity()) {
+            return;
         }
+        
+        $manipulator->addAttributeToClass(
+            'ORM\\UniqueConstraint',
+            [
+                'name' => 'UNIQ_IDENTIFIER_'.strtoupper(Str::asSnakeCase($userClassConfig->getIdentityPropertyName())),
+                'fields' => [$userClassConfig->getIdentityPropertyName()],
+            ]
+        );
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -264,14 +264,16 @@ private function addEraseCredentials(ClassSourceManipulator $manipulator): void`
`264`	`264`
`265`	`265`	`private function addUniqueConstraint(ClassSourceManipulator $manipulator, UserClassConfiguration $userClassConfig): void`
`266`	`266`	`{`
`267`		`- if ($userClassConfig->isEntity()) {`
`268`		`- $manipulator->addAttributeToClass(`
`269`		`- 'ORM\\UniqueConstraint',`
`270`		`- [`
`271`		`- 'name' => 'UNIQ_IDENTIFIER_'.strtoupper(Str::asSnakeCase($userClassConfig->getIdentityPropertyName())),`
`272`		`- 'fields' => [$userClassConfig->getIdentityPropertyName()],`
`273`		`- ]`
`274`		`- );`
	`267`	`+ if (!$userClassConfig->isEntity()) {`
	`268`	`+ return;`
`275`	`269`	`}`
	`270`	`+`
	`271`	`+ $manipulator->addAttributeToClass(`
	`272`	`+ 'ORM\\UniqueConstraint',`
	`273`	`+ [`
	`274`	`+ 'name' => 'UNIQ_IDENTIFIER_'.strtoupper(Str::asSnakeCase($userClassConfig->getIdentityPropertyName())),`
	`275`	`+ 'fields' => [$userClassConfig->getIdentityPropertyName()],`
	`276`	`+ ]`
	`277`	`+ );`
`276`	`278`	`}`
`277`	`279`	`}`