fix: PHP 8.4 deprecations

Chris8934 · Chris8934 · commit 6f59bff7add0 · 2025-01-14T17:13:31.000+01:00
diff --git a/templates/authenticator/EmptyAuthenticator.tpl.php b/templates/authenticator/EmptyAuthenticator.tpl.php
@@ -26,7 +26,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
         // TODO: Implement onAuthenticationFailure() method.
     }
 
-//    public function start(Request $request, AuthenticationException $authException = null): Response
+//    public function start(Request $request, ?AuthenticationException $authException = null): Response
 //    {
 //        /*
 //         * If you would like this class to control what happens when an anonymous user accesses a
diff --git a/templates/security/custom/Authenticator.tpl.php b/templates/security/custom/Authenticator.tpl.php
@@ -54,7 +54,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
         return new JsonResponse($data, Response::HTTP_UNAUTHORIZED);
     }
 
-    // public function start(Request $request, AuthenticationException $authException = null): Response
+    // public function start(Request $request, ?AuthenticationException $authException = null): Response
     // {
     //     /*
     //      * If you would like this class to control what happens when an anonymous user accesses a
diff --git a/templates/serializer/Normalizer.tpl.php b/templates/serializer/Normalizer.tpl.php
@@ -12,7 +12,7 @@ public function __construct(
     ) {
     }
 
-    public function normalize($object, string $format = null, array $context = []): array
+    public function normalize($object, ?string $format = null, array $context = []): array
     {
         $data = $this->normalizer->normalize($object, $format, $context);
 
@@ -21,7 +21,7 @@ public function normalize($object, string $format = null, array $context = []):
         return $data;
     }
 
-    public function supportsNormalization($data, string $format = null, array $context = []): bool
+    public function supportsNormalization($data, ?string $format = null, array $context = []): bool
     {
 <?php if ($entity_exists): ?>
         return $data instanceof <?= $entity_name ?>;
diff --git a/tests/fixtures/make-entity/regenerate-embedded/attributes/src/Entity/Money.php b/tests/fixtures/make-entity/regenerate-embedded/attributes/src/Entity/Money.php
@@ -16,7 +16,7 @@ class Money
     #[ORM\Column(name: 'amount')]
     private ?int $amount;
 
-    public function __construct($amount = null, Currency $currency = null)
+    public function __construct($amount = null, ?Currency $currency = null)
     {
         $this->amount = $amount;
         $this->currency = $currency ?? new Currency();
diff --git a/tests/fixtures/security/make-custom-authenticator/expected/FixtureAuthenticator.php b/tests/fixtures/security/make-custom-authenticator/expected/FixtureAuthenticator.php
@@ -63,7 +63,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
         return new JsonResponse($data, Response::HTTP_UNAUTHORIZED);
     }
 
-    // public function start(Request $request, AuthenticationException $authException = null): Response
+    // public function start(Request $request, ?AuthenticationException $authException = null): Response
     // {
     //     /*
     //      * If you would like this class to control what happens when an anonymous user accesses a

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio`
`26`	`26`	`// TODO: Implement onAuthenticationFailure() method.`
`27`	`27`	`}`
`28`	`28`
`29`		`-// public function start(Request $request, AuthenticationException $authException = null): Response`
	`29`	`+// public function start(Request $request, ?AuthenticationException $authException = null): Response`
`30`	`30`	`// {`
`31`	`31`	`// /*`
`32`	`32`	`// * If you would like this class to control what happens when an anonymous user accesses a`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio`
`54`	`54`	`return new JsonResponse($data, Response::HTTP_UNAUTHORIZED);`
`55`	`55`	`}`
`56`	`56`
`57`		`- // public function start(Request $request, AuthenticationException $authException = null): Response`
	`57`	`+ // public function start(Request $request, ?AuthenticationException $authException = null): Response`
`58`	`58`	`// {`
`59`	`59`	`// /*`
`60`	`60`	`// * If you would like this class to control what happens when an anonymous user accesses a`
Original file line number	Diff line number	Diff line change
`@@ -12,7 +12,7 @@ public function __construct(`
`12`	`12`	`) {`
`13`	`13`	`}`
`14`	`14`
`15`		`- public function normalize($object, string $format = null, array $context = []): array`
	`15`	`+ public function normalize($object, ?string $format = null, array $context = []): array`
`16`	`16`	`{`
`17`	`17`	`$data = $this->normalizer->normalize($object, $format, $context);`
`18`	`18`
`@@ -21,7 +21,7 @@ public function normalize($object, string $format = null, array $context = []):`
`21`	`21`	`return $data;`
`22`	`22`	`}`
`23`	`23`
`24`		`- public function supportsNormalization($data, string $format = null, array $context = []): bool`
	`24`	`+ public function supportsNormalization($data, ?string $format = null, array $context = []): bool`
`25`	`25`	`{`
`26`	`26`	`<?php if ($entity_exists): ?>`
`27`	`27`	`return $data instanceof <?= $entity_name ?>;`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ class Money`
`16`	`16`	`#[ORM\Column(name: 'amount')]`
`17`	`17`	`private ?int $amount;`
`18`	`18`
`19`		`- public function __construct($amount = null, Currency $currency = null)`
	`19`	`+ public function __construct($amount = null, ?Currency $currency = null)`
`20`	`20`	`{`
`21`	`21`	`$this->amount = $amount;`
`22`	`22`	`$this->currency = $currency ?? new Currency();`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio`
`63`	`63`	`return new JsonResponse($data, Response::HTTP_UNAUTHORIZED);`
`64`	`64`	`}`
`65`	`65`
`66`		`- // public function start(Request $request, AuthenticationException $authException = null): Response`
	`66`	`+ // public function start(Request $request, ?AuthenticationException $authException = null): Response`
`67`	`67`	`// {`
`68`	`68`	`// /*`
`69`	`69`	`// * If you would like this class to control what happens when an anonymous user accesses a`