improve readability

IndraGunawan · IndraGunawan · commit 339202e1bd7b · 2024-02-29T23:44:07.000+08:00
diff --git a/src/Doctrine/DoctrineHelper.php b/src/Doctrine/DoctrineHelper.php
@@ -273,18 +273,22 @@ public static function getPropertyTypeForColumn(string $columnType): ?string
             default => null,
         };
 
-        if (null === $propertyType && Type::getTypeRegistry()->has($columnType)) {
-            $reflection = new \ReflectionClass(\get_class(Type::getTypeRegistry()->get($columnType)));
-            if ($reflection->hasMethod('convertToPHPValue') && $returnType = $reflection->getMethod('convertToPHPValue')->getReturnType()) {
-                if ($returnType->isBuiltin()) {
-                    $propertyType = $returnType->getName();
-                } else {
-                    $propertyType = '\\'.$returnType->getName();
-                }
-            }
+        if (null !== $propertyType || !($registry = Type::getTypeRegistry())->has($columnType)) {
+            return $propertyType;
+        }
+
+        $reflection = new \ReflectionClass(($registry->get($columnType))::class);
+
+        $returnType = $reflection->getMethod('convertToPHPValue')->getReturnType();
+
+        /*
+         * we do not support union and intersection types
+         */
+        if (!$returnType instanceof \ReflectionNamedType) {
+            return null;
         }
 
-        return $propertyType;
+        return $returnType->isBuiltin() ? $returnType->getName() : '\\'.$returnType->getName();
     }
 
     /**
