minor #1657 Fix indentation of options_code (nicolas-grekas)

kbond · kbond · commit 2b80d6bfec0f · 2025-03-26T08:19:46.000-04:00
This PR was merged into the 1.x-dev branch. Discussion ---------- Fix indentation of options_code Similar to #1469 but doesn't rely on any CS fixer. Note that using PHP_EOL was wrong: this constant is meant to be used ONLY when outputting something on a terminal. NOT when dealing with new lines in files. Commits ------- 91b7ce0 Fix indentation of options_code
diff --git a/src/Doctrine/EntityDetails.php b/src/Doctrine/EntityDetails.php
@@ -77,11 +77,11 @@ public function getFormFields(): array
             }
             $fieldsWithTypes[$fieldName] = [
                 'type' => EntityType::class,
-                'options_code' => \sprintf('\'class\' => %s::class,', $relation['targetEntity']).\PHP_EOL.'\'choice_label\' => \'id\',',
+                'options_code' => \sprintf('\'class\' => %s::class,', $relation['targetEntity'])."\n                'choice_label' => 'id',",
                 'extra_use_classes' => [$relation['targetEntity']],
             ];
             if (\Doctrine\ORM\Mapping\ClassMetadata::MANY_TO_MANY === $relation['type']) {
-                $fieldsWithTypes[$fieldName]['options_code'] .= "\n'multiple' => true,";
+                $fieldsWithTypes[$fieldName]['options_code'] .= "\n                'multiple' => true,";
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -77,11 +77,11 @@ public function getFormFields(): array`
`77`	`77`	`}`
`78`	`78`	`$fieldsWithTypes[$fieldName] = [`
`79`	`79`	`'type' => EntityType::class,`
`80`		`- 'options_code' => \sprintf('\'class\' => %s::class,', $relation['targetEntity']).\PHP_EOL.'\'choice_label\' => \'id\',',`
	`80`	`+ 'options_code' => \sprintf('\'class\' => %s::class,', $relation['targetEntity'])."\n 'choice_label' => 'id',",`
`81`	`81`	`'extra_use_classes' => [$relation['targetEntity']],`
`82`	`82`	`];`
`83`	`83`	`if (\Doctrine\ORM\Mapping\ClassMetadata::MANY_TO_MANY === $relation['type']) {`
`84`		`- $fieldsWithTypes[$fieldName]['options_code'] .= "\n'multiple' => true,";`
	`84`	`+ $fieldsWithTypes[$fieldName]['options_code'] .= "\n 'multiple' => true,";`
`85`	`85`	`}`
`86`	`86`	`}`
`87`	`87`