minor #42165 Simplify some code with null coalesce operator (javiereguiluz)

derrabus · derrabus · commit 6dfb6c5b60c5 · 2021-07-18T18:24:23.000+02:00
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

Simplify some code with null coalesce operator

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

For your consideration. There are many other possible usages of null coalesce operator, but the result is not very readable ... so this PR only contains the changes where the result is clearly better.

Commits
-------

17ad5b75fa Simplify some code with null coalesce operator
diff --git a/EventListener/DebugHandlersListener.php b/EventListener/DebugHandlersListener.php
@@ -60,7 +60,7 @@ public function __construct(callable $exceptionHandler = null, LoggerInterface $
 
         $this->exceptionHandler = $exceptionHandler;
         $this->logger = $logger;
-        $this->levels = null === $levels ? \E_ALL : $levels;
+        $this->levels = $levels ?? \E_ALL;
         $this->throwAt = \is_int($throwAt) ? $throwAt : (null === $throwAt ? null : ($throwAt ? \E_ALL : null));
         $this->scream = $scream;
         $this->fileLinkFormat = $fileLinkFormat;
diff --git a/Profiler/Profile.php b/Profiler/Profile.php
@@ -156,11 +156,7 @@ public function setUrl($url)
      */
     public function getTime()
     {
-        if (null === $this->time) {
-            return 0;
-        }
-
-        return $this->time;
+        return $this->time ?? 0;
     }
 
     /**
diff --git a/Tests/KernelTest.php b/Tests/KernelTest.php
@@ -709,7 +709,7 @@ protected function getBundle($dir = null, $parent = null, $className = null, $bu
         $bundle
             ->expects($this->any())
             ->method('getName')
-            ->willReturn(null === $bundleName ? \get_class($bundle) : $bundleName)
+            ->willReturn($bundleName ?? \get_class($bundle))
         ;
 
         $bundle

Original file line number	Diff line number	Diff line change
`@@ -156,11 +156,7 @@ public function setUrl($url)`
`156`	`*/`
`157`	`157`	`public function getTime()`
`158`	`158`	`{`
`159`		`- if (null === $this->time) {`
`160`		`- return 0;`
`161`		`- }`
`162`		`-`
`163`		`- return $this->time;`
	`159`	`+ return $this->time ?? 0;`
`164`	`160`	`}`
`165`	`161`
`166`	`162`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -709,7 +709,7 @@ protected function getBundle($dir = null, $parent = null, $className = null, $bu`
`709`	`709`	`$bundle`
`710`	`710`	`->expects($this->any())`
`711`	`711`	`->method('getName')`
`712`		`- ->willReturn(null === $bundleName ? \get_class($bundle) : $bundleName)`
	`712`	`+ ->willReturn($bundleName ?? \get_class($bundle))`
`713`	`713`	`;`
`714`	`714`
`715`	`715`	`$bundle`