8000 bug #26041 Display the Welcome Page when there is no homepage defined… · symfony/http-kernel@558a4dc · GitHub
[go: up one dir, main page]

Skip to content

Commit 558a4dc

Browse files
committed
bug #26041 Display the Welcome Page when there is no homepage defined (javiereguiluz)
This PR was squashed before being merged into the 3.4 branch (closes #26041). Discussion ---------- Display the Welcome Page when there is no homepage defined | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony-docs#9178 | License | MIT | Doc PR | - In 3.4 we added a trick to display the Welcome Page when the user browses `/` and there are no routes defined. However, when using the `website-skeleton` (which is what most newcomers use ... and they are the ones that mostly need the "Welcome Page") the premise about *"no routes are defined"* is never true and the Welcome Page is never shown (see symfony/symfony-docs#9178 for one of the multiple error reports we've received). So, I propose to make this change to always define the "Welcome Page" as the fallback: * If no routes are defined for `/`, the Welcome Page is displayed. * If there is a route defined for `/`, this code will never be executed because it's the last condition of the routing matcher. Commits ------- 5b0d934 Display the Welcome Page when there is no homepage defined
2 parents 66a0fe6 + b100d75 commit 558a4dc

File tree

Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
</div>
7777
<div id="comment">
7878
<p>
79-
You're seeing this message because you have debug mode enabled and you haven't configured any URLs.
79+
You're seeing this page because debug mode is enabled and you haven't configured any homepage URL.
8080
</p>
8181
</div>
8282
</div>