From 54118c6340dc6831a00f10b296ea6e80592ec89d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Tamarelle?= Date: Mon, 23 Sep 2024 11:24:18 +0200 Subject: [PATCH 1/3] Add PR template and auto-close PR on subtree split repositories --- .gitattributes | 3 +-- .github/PULL_REQUEST_TEMPLATE.md | 8 ++++++++ .github/workflows/close-pull-request.yml | 20 ++++++++++++++++++++ 3 files changed, 29 insertions(+), 2 deletions(-) create mode 100644 .github/PULL_REQUEST_TEMPLATE.md create mode 100644 .github/workflows/close-pull-request.yml diff --git a/.gitattributes b/.gitattributes index 84c7add0..14c3c359 100644 --- a/.gitattributes +++ b/.gitattributes @@ -1,4 +1,3 @@ /Tests export-ignore /phpunit.xml.dist export-ignore -/.gitattributes export-ignore -/.gitignore export-ignore +/.git* export-ignore diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 00000000..4689c4da --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,8 @@ +Please do not submit any Pull Requests here. They will be closed. +--- + +Please submit your PR here instead: +https://github.com/symfony/symfony + +This repository is what we call a "subtree split": a read-only subset of that main repository. +We're looking forward to your PR there! diff --git a/.github/workflows/close-pull-request.yml b/.github/workflows/close-pull-request.yml new file mode 100644 index 00000000..e55b4781 --- /dev/null +++ b/.github/workflows/close-pull-request.yml @@ -0,0 +1,20 @@ +name: Close Pull Request + +on: + pull_request_target: + types: [opened] + +jobs: + run: + runs-on: ubuntu-latest + steps: + - uses: superbrothers/close-pull-request@v3 + with: + comment: | + Thanks for your Pull Request! We love contributions. + + However, you should instead open your PR on the main repository: + https://github.com/symfony/symfony + + This repository is what we call a "subtree split": a read-only subset of that main repository. + We're looking forward to your PR there! From 509d0e8a798bf5e41e0b6317e9bce1140af47376 Mon Sep 17 00:00:00 2001 From: Alexandre Daubois Date: Mon, 14 Oct 2024 20:15:01 +0200 Subject: [PATCH 2/3] [HttpClient] Fix class requirement message --- CachingHttpClient.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CachingHttpClient.php b/CachingHttpClient.php index b05b8263..34bc1189 100644 --- a/CachingHttpClient.php +++ b/CachingHttpClient.php @@ -42,7 +42,7 @@ class CachingHttpClient implements HttpClientInterface, ResetInterface public function __construct(HttpClientInterface $client, StoreInterface $store, array $defaultOptions = []) { if (!class_exists(HttpClientKernel::class)) { - throw new \LogicException(sprintf('Using "%s" requires that the HttpKernel component version 4.3 or higher is installed, try running "composer require symfony/http-kernel:^5.4".', __CLASS__)); + throw new \LogicException(sprintf('Using "%s" requires the HttpKernel component, try running "composer require symfony/http-kernel".', __CLASS__)); } $this->client = $client; From 274e2f6886b43a36f8bd5dfeb67215f7ebf9e291 Mon Sep 17 00:00:00 2001 From: Jordi Boggiano Date: Tue, 22 Oct 2024 11:40:50 +0200 Subject: [PATCH 3/3] Fix typo in deprecation message --- NoPrivateNetworkHttpClient.php | 4 ++-- ScopingHttpClient.php | 4 ++-- TraceableHttpClient.php | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/NoPrivateNetworkHttpClient.php b/NoPrivateNetworkHttpClient.php index 3b930ad3..77d7bdf6 100644 --- a/NoPrivateNetworkHttpClient.php +++ b/NoPrivateNetworkHttpClient.php @@ -78,11 +78,11 @@ public function stream(ResponseInterface|iterable $responses, ?float $timeout = } /** - * @deprecated since Symfony 7.1, configure the logger on the wrapper HTTP client directly instead + * @deprecated since Symfony 7.1, configure the logger on the wrapped HTTP client directly instead */ public function setLogger(LoggerInterface $logger): void { - trigger_deprecation('symfony/http-client', '7.1', 'Configure the logger on the wrapper HTTP client directly instead.'); + trigger_deprecation('symfony/http-client', '7.1', 'Configure the logger on the wrapped HTTP client directly instead.'); if ($this->client instanceof LoggerAwareInterface) { $this->client->setLogger($logger); diff --git a/ScopingHttpClient.php b/ScopingHttpClient.php index 0086b2d1..948d40a1 100644 --- a/ScopingHttpClient.php +++ b/ScopingHttpClient.php @@ -101,11 +101,11 @@ public function reset(): void } /** - * @deprecated since Symfony 7.1, configure the logger on the wrapper HTTP client directly instead + * @deprecated since Symfony 7.1, configure the logger on the wrapped HTTP client directly instead */ public function setLogger(LoggerInterface $logger): void { - trigger_deprecation('symfony/http-client', '7.1', 'Configure the logger on the wrapper HTTP client directly instead.'); + trigger_deprecation('symfony/http-client', '7.1', 'Configure the logger on the wrapped HTTP client directly instead.'); if ($this->client instanceof LoggerAwareInterface) { $this->client->setLogger($logger); diff --git a/TraceableHttpClient.php b/TraceableHttpClient.php index b6d30dab..4168c3c4 100644 --- a/TraceableHttpClient.php +++ b/TraceableHttpClient.php @@ -90,11 +90,11 @@ public function reset(): void } /** - * @deprecated since Symfony 7.1, configure the logger on the wrapper HTTP client directly instead + * @deprecated since Symfony 7.1, configure the logger on the wrapped HTTP client directly instead */ public function setLogger(LoggerInterface $logger): void { - trigger_deprecation('symfony/http-client', '7.1', 'Configure the logger on the wrapper HTTP client directly instead.'); + trigger_deprecation('symfony/http-client', '7.1', 'Configure the logger on the wrapped HTTP client directly instead.'); if ($this->client instanceof LoggerAwareInterface) { $this->client->setLogger($logger);