feature #28598 [Cache] support configuring multiple Memcached servers in one DSN (nicolas-grekas)

fabpot · fabpot · commit f34ad5255250 · 2018-09-26T07:51:01.000+02:00
This PR was merged into the 4.2-dev branch. Discussion ---------- [Cache] support configuring multiple Memcached servers in one DSN | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #27855 | License | MIT | Doc PR | symfony/symfony-docs#10402 Useful to reconfigure dynamically an array of memcached servers (eg removing a dead one or adding a new one). DSN format is e.g. `memcached://localhost?host[foo.bar]=3`. To ease generating the DSN programmatically, it works also with `memcached:?host[localhost]&host[localhost:12345]&host[/some/memcached.sock:]=3`. The key of the "host" parameter is a "host:port" pair, the value is the weight of the "host:port" pair. Sockets need to be specified with the trailing `:` (as shown in the last example). Commits ------- 8e0605ac18 [Cache] support configuring multiple Memcached servers in one DSN
diff --git a/DependencyInjection/Compiler/CachePoolPass.php b/DependencyInjection/Compiler/CachePoolPass.php
@@ -133,7 +133,7 @@ public static function getServiceProvider(ContainerBuilder $container, $name)
     {
         $container->resolveEnvPlaceholders($name, null, $usedEnvs);
 
-        if ($usedEnvs || preg_match('#^[a-z]++://#', $name)) {
+        if ($usedEnvs || preg_match('#^[a-z]++:#', $name)) {
             $dsn = $name;
 
             if (!$container->hasDefinition($name = '.cache_connection.'.ContainerBuilder::hash($dsn))) {

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ public static function getServiceProvider(ContainerBuilder $container, $name)`
`133`	`133`	`{`
`134`	`134`	`$container->resolveEnvPlaceholders($name, null, $usedEnvs);`
`135`	`135`
`136`		`- if ($usedEnvs \|\| preg_match('#^[a-z]++://#', $name)) {`
	`136`	`+ if ($usedEnvs \|\| preg_match('#^[a-z]++:#', $name)) {`
`137`	`137`	`$dsn = $name;`
`138`	`138`
`139`	`139`	`if (!$container->hasDefinition($name = '.cache_connection.'.ContainerBuilder::hash($dsn))) {`