8000 feature #50754 [HttpKernel] when configuring the container add servic… · symfony/framework-bundle@636e777 · GitHub
[go: up one dir, main page]
Skip to content

Commit 636e777

Browse files
chalasrchalasr
committed
feature #50754 [HttpKernel] when configuring the container add services_{env} with php extension (helyakin)
This PR was merged into the 6.4 branch. Discussion ---------- [HttpKernel] when configuring the container add services_{env} with php extension | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | none | License | MIT Hello the community This is my first PR attempt. So after reading this [documentation](https://symfony.com/doc/current/service_container.html#remove-services) and unsuccessfully trying to load my `service_test.php`, I've noticed that the `configureContainer(..)` function in the `MicroKernelTrait` file was not configured to automatically load this file. So either we should fix the documentation, either we should fix the configuration. Since this the [framework-bundle](https://github.com/symfony/framework-bundle) is backed by [Alximy](https://alximy.io) I figured it would be cool 😎 to try and fix 🐛 the configuration. Anyway share me your thoughts about what should be done ! And I wanted to say that php service configuration is 🔥 so shoutout to the one who did this (I think it's you `@nicolas`-grekas with this [PR](symfony/symfony#23834) right ? 💪🏻) Also big thanks to `@jeremyFreeAgent` for debugging this with me and `@HeahDude` for showing me the php service configuration PR. Commits ------- 4aac1d9fee 🐛 (kernel) when configuring the container add services with php ext
2 parents c587925 + cace4e0 commit 636e777

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

‎Kernel/MicroKernelTrait.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,7 @@ private function configureContainer(ContainerConfigurator $container, LoaderInte
5858
$container->import($configDir.'/{services}_'.$this->environment.'.yaml');
5959
} else {
6060
$container->import($configDir.'/{services}.php');
61+
$container->import($configDir.'/{services}_'.$this->environment.'.php');
6162
}
6263
}
6364

0 commit comments

Comments
 (0)
0