Test improvements, use Nowdoc instead of Heredoc if possible #600
Conversation
|
Is there any particular reason for this change? I'm curious |
|
@Pierstoval From the official PHP documentation https://www.php.net/manual/en/language.types.string.php#language.types.string.syntax.nowdoc |
|
I know this difference, but this doesn't seem to me like a recommendation. There's no mention of heredoc nor nowdoc in PSRs either, that's why I'm asking why you think it would be better to use one over the other in Flex. I'm not against the change, I'm just curious :) |
|
It's only the micro-optimization. I found it, when explored code of Symfony Flex. I updated only those strings, which don't contain php variables inside, so heredoc could be changed with nowdoc without side effects. |
|
Seems fair 👍 |
|
Thank you. I'm going to close because we don't do CS changes when they can't be enforced by our CS checker, fabbot based on php-cs-fixer. Without a bot, these changes are arbitrary and the "target" achieved here won't last long as a future PR might break it very easily. Thanks for proposing. |
|
(php-cs-fixer has a fixer for this ( |
No description provided.