[CS][2.7] yoda_style, no_unneeded_curly_braces, no_unneeded_final_method, semicolon_after_instruction

SpacePossum · nicolas-grekas · commit 2a867f563c87 · 2017-09-15T11:46:57.000+02:00
diff --git a/Filesystem.php b/Filesystem.php
@@ -404,7 +404,7 @@ public function makePathRelative($endPath, $startPath)
         }
 
         // Determine how deep the start path is relative to the common path (ie, "web/bundles" = 2 levels)
-        if (count($startPathArr) === 1 && $startPathArr[0] === '') {
+        if (1 === count($startPathArr) && '' === $startPathArr[0]) {
             $depth = 0;
         } else {
             $depth = count($startPathArr) - $index;
@@ -512,7 +512,7 @@ public function isAbsolutePath($file)
     {
         return strspn($file, '/\\', 0, 1)
             || (strlen($file) > 3 && ctype_alpha($file[0])
-                && substr($file, 1, 1) === ':'
+                && ':' === substr($file, 1, 1)
                 && strspn($file, '/\\', 2, 1)
             )
             || null !== parse_url($file, PHP_URL_SCHEME)

Original file line number	Diff line number	Diff line change
`@@ -404,7 +404,7 @@ public function makePathRelative($endPath, $startPath)`
`404`	`404`	`}`
`405`	`405`
`406`	`406`	`// Determine how deep the start path is relative to the common path (ie, "web/bundles" = 2 levels)`
`407`		`- if (count($startPathArr) === 1 && $startPathArr[0] === '') {`
	`407`	`+ if (1 === count($startPathArr) && '' === $startPathArr[0]) {`
`408`	`408`	`$depth = 0;`
`409`	`409`	`} else {`
`410`	`410`	`$depth = count($startPathArr) - $index;`
`@@ -512,7 +512,7 @@ public function isAbsolutePath($file)`
`512`	`512`	`{`
`513`	`513`	`return strspn($file, '/\\', 0, 1)`
`514`	`514`	`\|\| (strlen($file) > 3 && ctype_alpha($file[0])`
`515`		`- && substr($file, 1, 1) === ':'`
	`515`	`+ && ':' === substr($file, 1, 1)`
`516`	`516`	`&& strspn($file, '/\\', 2, 1)`
`517`	`517`	`)`
`518`	`518`	`\|\| null !== parse_url($file, PHP_URL_SCHEME)`