feature #48992 [HttpKernel] Introduce pinnable value resolvers with #[ValueResolver] and #[AsPinnedValueResolver] (MatTheCat)

nicolas-grekas · nicolas-grekas · commit 669b167a7bf2 · 2023-03-06T14:48:37.000+01:00
This PR was merged into the 6.3 branch. Discussion ---------- [HttpKernel] Introduce pinnable value resolvers with `#[ValueResolver]` and `#[AsPinnedValueResolver]` | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #48927 | License | MIT | Doc PR | symfony/symfony-docs#17763 Introducing a new `ValueResolver` attribute, which allows to - “pin” a value resolver to an argument, meaning only said resolver will be called - prevent a resolver to be called for an argument Every existing resolver-related attribute (`MapEntity`, `CurrentUser`…) now extends `ValueResolver`. Each `controller.argument_value_resolver` tag is added a `name` attribute, which is the resolver’s FQCN. This is the first argument `ValueResolver` expects. A new `AsPinnedValueResolver` attribute is added for autoconfiguration, adding the `controller.pinned_value_resolver` tag. Such resolvers can only be “pinned”, meaning they won’t ever be called for an argument missing the `ValueResolver` attribute. Commits ------- 245485c2a7 [HttpKernel] Introduce pinnable value resolvers with `#[ValueResolver]` and `#[AsPinnedValueResolver]`
diff --git a/Attribute/MapEntity.php b/Attribute/MapEntity.php
@@ -11,11 +11,14 @@
 
 namespace Symfony\Bridge\Doctrine\Attribute;
 
+use Symfony\Bridge\Doctrine\ArgumentResolver\EntityValueResolver;
+use Symfony\Component\HttpKernel\Attribute\ValueResolver;
+
 /**
  * Indicates that a controller argument should receive an Entity.
  */
 #[\Attribute(\Attribute::TARGET_PARAMETER)]
-class MapEntity
+class MapEntity extends ValueResolver
 {
     public function __construct(
         public ?string $class = null,
@@ -26,8 +29,10 @@ public function __construct(
         public ?bool $stripNull = null,
         public array|string|null $id = null,
         public ?bool $evictCache = null,
-        public bool $disabled = false,
+        bool $disabled = false,
+        string $resolver = EntityValueResolver::class,
     ) {
+        parent::__construct($resolver, $disabled);
     }
 
     public function withDefaults(self $defaults, ?string $class): static
diff --git a/composer.json b/composer.json
@@ -30,7 +30,7 @@
         "symfony/config": "^5.4|^6.0",
         "symfony/dependency-injection": "^6.2",
         "symfony/form": "^5.4.21|^6.2.7",
-        "symfony/http-kernel": "^6.2",
+        "symfony/http-kernel": "^6.3",
         "symfony/messenger": "^5.4|^6.0",
         "symfony/doctrine-messenger": "^5.4|^6.0",
         "symfony/property-access": "^5.4|^6.0",
