minor #21766 [DI] Remove experimental status from service-locator argument type (chalasr)

fabpot · fabpot · commit 0897b79ab1db · 2017-02-26T14:51:27.000-08:00
This PR was merged into the 3.3-dev branch. Discussion ---------- [DI] Remove experimental status from service-locator argument type | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony/symfony#21625 (comment), symfony/symfony#21625 (comment), #21710 | License | MIT The `service-locator` argument type is not controversial to me. We know its scope, nothing really surprising, just a map of services to be lazily loaded like `iterator` is (which is not experimental) but keyed. About its api, it's just PSR-11 restricted to objects, nothing that can't be changed safely in the future. As stated in symfony/symfony#21625 (comment), it proven its usefulness already. I think what we were looking for by flagging it experimental is just to see it in action, we've 3 opened PRs for that (#21625, #21690, #21730). This allows introducing deprecations for making use of the feature in the core, thus unlocks #21625 and #21690. Commits ------- 46dc47af11 [DI] Remove experimental status from service-locator argument type
diff --git a/Argument/ServiceLocatorArgument.php b/Argument/ServiceLocatorArgument.php
@@ -18,8 +18,6 @@
  * Represents a service locator able to lazy load a given range of services.
  *
  * @author Robin Chalas <robin.chalas@gmail.com>
- *
- * @experimental in version 3.3
  */
 class ServiceLocatorArgument implements ArgumentInterface
 {
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -5,7 +5,7 @@ CHANGELOG
 -----
 
  * [EXPERIMENTAL] added "instanceof" section for local interface-defined configs
- * [EXPERIMENTAL] added "service-locator" argument for lazy loading a set of identified values and services
+ * added "service-locator" argument for lazy loading a set of identified values and services
  * [EXPERIMENTAL] added prototype services for PSR4-based discovery and registration
  * added `ContainerBuilder::getReflectionClass()` for retrieving and tracking reflection class info
  * deprecated `ContainerBuilder::getClassResource()`, use `ContainerBuilder::getReflectionClass()` or `ContainerBuilder::addObjectResource()` instead
diff --git a/ServiceLocator.php b/ServiceLocator.php
@@ -18,8 +18,6 @@
 /**
  * @author Robin Chalas <robin.chalas@gmail.com>
  * @author Nicolas Grekas <p@tchwork.com>
- *
- * @experimental in version 3.3
  */
 class ServiceLocator implements PsrContainerInterface
 {

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,6 @@`
`18`	`18`	`* Represents a service locator able to lazy load a given range of services.`
`19`	`19`	`*`
`20`	`20`	`* @author Robin Chalas <robin.chalas@gmail.com>`
`21`		`- *`
`22`		`- * @experimental in version 3.3`
`23`	`21`	`*/`
`24`	`22`	`class ServiceLocatorArgument implements ArgumentInterface`
`25`	`23`	`{`