10000 Translation broke after upgrading to Symfony 4.2 beta1 · Issue #889 · symfony/demo · GitHub
[go: up one dir, main page]
Skip to content

Translation broke after upgrading to Symfony 4.2 beta1 #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Nov 6, 2018 · 4 comments
Closed

Translation broke after upgrading to Symfony 4.2 beta1 #889

javiereguiluz opened this issue Nov 6, 2018 · 4 comments
Labels
bug good first issue Ideal for your first contribution! (some Symfony experience may be required)

Comments

@javiereguiluz
Copy link
Member

Translated messages using the new format no longer work:

i18n-error

This is probably because we need to add the suffix in the translation messages to enable the new format explicitly.
@ogizanagi
Copy link
Contributor

I think you just need to rename translations files with the +intl-icu suffix:

- messages.en.xlf
+ messages+intl-icu.en.xlf

(symfony/symfony#28952)

@javiereguiluz javiereguiluz added the good first issue Ideal for your first contribution! (some Symfony experience may be required) label Nov 6, 2018
@gmsantos
Copy link
Contributor
gmsantos commented Nov 6, 2018

@javiereguiluz I will work on that

@javiereguiluz
Copy link
Member Author

@gmsantos great! Thanks a lot.

@gmsantos gmsantos mentioned this issue Nov 6, 2018
Closed
@javiereguiluz
Copy link
Member Author

Fixed by #890.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javiereguiluz @gmsantos @ogizanagi
0