8000 feature #1530 Use Symfony UX Icons (javiereguiluz) · symfony/demo@f39ffa0 · GitHub
[go: up one dir, main page]
Skip to content

Commit f39ffa0

Browse files
javiereguiluzjaviereguiluz
committed
feature #1530 Use Symfony UX Icons (javiereguiluz)
This PR was squashed before being merged into the main branch. Discussion ---------- Use Symfony UX Icons Let's start using more UX packages in this project. I propose to use Tabler icons because we use them in all Symfony websites, in the Symfony Profiler and Toolbar, etc. I'm pinging `@smnandre` and `@Kocal` because I have a question. I had to apply these attributes by default: ```yaml ux_icons: default_icon_attributes: width: 1.2em height: 1.2em style: 'position: relative; top: -2px;' ``` If I don't, the icons look very small and not aligned vertically: * The alignment is ideally solved by using `flex` in buttons and other elements that display icons + text. Since I'd like to add Twig Components here, I prefer to not change HTML/CSS much and instead, apply these attributes as a trade-off until we solve this in a better way. * About the small icon size, I don't know why they look so small with the default `1em`. Any help is appreciated. Thanks! Commits ------- 986f239 Use Symfony UX Icons
2 parents eba4f92 + 986f239 commit f39ffa0

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

57 files changed

+103
-73
lines changed

‎assets/app.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
// start the Stimulus application
22
import './bootstrap.js';
33
import './styles/app.scss';
4-
import '@fortawesome/fontawesome-free/css/all.css';
5-
import '@fortawesome/fontawesome-free/css/v4-shims.css';
64
import 'highlight.js/styles/github-dark-dimmed.css';
75
import 'lato-font/css/lato-font.css';
86

‎assets/icons/tabler/arrow-left.svg

Lines changed: 1 addition & 0 deletions

‎assets/icons/tabler/arrow-right.svg

Lines changed: 1 addition & 0 deletions

‎assets/icons/tabler/ban.svg

Lines changed: 1 addition & 0 deletions

‎assets/icons/tabler/brand-x.svg

Lines changed: 1 addition & 0 deletions

‎assets/icons/tabler/calendar-month.svg

Lines changed: 1 addition & 0 deletions

‎assets/icons/tabler/code.svg

Lines changed: 1 addition & 0 deletions

‎assets/icons/tabler/device-floppy.svg

Lines changed: 1 addition & 0 deletions

‎assets/icons/tabler/eye.svg

Lines changed: 1 addition & 0 deletions

‎assets/icons/tabler/home.svg

Lines changed: 1 addition & 0 deletions

0 commit comments

Comments
 (0)
0