[Console][PhpUnitBridge][VarDumper] Fix NO_COLOR empty value handling

alexandre-daubois · alexandre-daubois · commit cef62396a047 · 2024-07-26T14:21:55.000+02:00
diff --git a/Output/StreamOutput.php b/Output/StreamOutput.php
@@ -91,7 +91,7 @@ protected function doWrite(string $message, bool $newline)
     protected function hasColorSupport()
     {
         // Follow https://no-color.org/
-        if (isset($_SERVER['NO_COLOR']) || false !== getenv('NO_COLOR')) {
+        if ('' !== ($_SERVER['NO_COLOR'] ?? getenv('NO_COLOR') ?: '')) {
             return false;
         }
 

Original file line number	Diff line number	Diff line change
`@@ -91,7 +91,7 @@ protected function doWrite(string $message, bool $newline)`
`91`	`91`	`protected function hasColorSupport()`
`92`	`92`	`{`
`93`	`93`	`// Follow https://no-color.org/`
`94`		`- if (isset($_SERVER['NO_COLOR']) \|\| false !== getenv('NO_COLOR')) {`
	`94`	`+ if ('' !== ($_SERVER['NO_COLOR'] ?? getenv('NO_COLOR') ?: '')) {`
`95`	`95`	`return false;`
`96`	`96`	`}`
`97`	`97`