Merge branch '4.3' into 4.4

nicolas-grekas · nicolas-grekas · commit af50d14ada9e · 2019-10-04T23:43:27.000+02:00
* 4.3:
  [Intl] Update the ICU data to 65.1 (4.3 branch)
  Replace deprecated calls in tests
  [Intl] Update the ICU data to 65.1
  Delete 5_Security_issue.md
  [DI] Whitelist validator.auto_mapper in UnusedTagsPass
  [HttpClient] Fixed #33832 NO_PROXY option ignored in NativeHttpClient::request() method
  [Cache] give 100ms before starting the expiration countdown
  [Cache] fix logger usage in CacheTrait::doGet()
  [VarDumper] fix dumping uninitialized SplFileInfo
  Added missing translations.
  Fixed invalid changelog 4.0.0 for VarDumper
  Fixed invalid VarDumper upgrade doc.
  [HttpFoundation] Check if data passed to SessionBagProxy::initialize is an array
  Don't let falsey usernames slip through
diff --git a/CacheTrait.php b/CacheTrait.php
@@ -56,7 +56,7 @@ private function doGet(CacheItemPoolInterface $pool, string $key, callable $call
             if ($recompute = $ctime && $expiry && $expiry <= ($now = microtime(true)) - $ctime / 1000 * $beta * log(random_int(1, PHP_INT_MAX) / PHP_INT_MAX)) {
                 // force applying defaultLifetime to expiry
                 $item->expiresAt(null);
-                $this->logger && $this->logger->info('Item "{key}" elected for early recomputation {delta}s before its expiration', [
+                $logger && $logger->info('Item "{key}" elected for early recomputation {delta}s before its expiration', [
                     'key' => $key,
                     'delta' => sprintf('%.1f', $expiry - $now),
                 ]);
