Merge branch '4.2' into 4.3

nicolas-grekas · nicolas-grekas · commit a29dd02a1f3f · 2019-06-11T17:41:59.000+02:00
* 4.2: [WebProfilerBundle] fix FC with HttpFoundation v5 [OptionsResolver] fix adding $triggerDeprecation to Options::offsetGet() [Form] test case is not legacy Fix reporting unsilenced deprecations from insulated tests Added FormInterface to @return Form::getClickedButton docblock
diff --git a/Client.php b/Client.php
@@ -459,7 +459,8 @@ protected function doRequestInProcess($request)
             unlink($deprecationsFile);
             foreach ($deprecations ? unserialize($deprecations) : [] as $deprecation) {
                 if ($deprecation[0]) {
-                    @trigger_error($deprecation[1], E_USER_DEPRECATED);
+                    // unsilenced on purpose
+                    trigger_error($deprecation[1], E_USER_DEPRECATED);
                 } else {
                     @trigger_error($deprecation[1], E_USER_DEPRECATED);
                 }
