Merge branch '3.4' into 4.4

nicolas-grekas · nicolas-grekas · commit 56bede5618a9 · 2020-05-16T12:07:46.000+02:00
* 3.4:
  [VarDumper] fix for change in PHP 7.4.6 (bis)
  [BrowserKit] Allow Referer set by history to be overridden (3.4)
diff --git a/Client.php b/Client.php
@@ -380,7 +380,7 @@ public function request(string $method, string $uri, array $parameters = [], arr
             $uri = preg_replace('{^'.parse_url($uri, PHP_URL_SCHEME).'}', $server['HTTPS'] ? 'https' : 'http', $uri);
         }
 
-        if (!$this->history->isEmpty()) {
+        if (!isset($server['HTTP_REFERER']) && !$this->history->isEmpty()) {
             $server['HTTP_REFERER'] = $this->history->current()->getUri();
         }
 
diff --git a/Tests/AbstractBrowserTest.php b/Tests/AbstractBrowserTest.php
@@ -230,6 +230,15 @@ public function testRequestReferer()
         $this->assertEquals('http://www.example.com/foo/foobar', $server['HTTP_REFERER'], '->request() sets the referer');
     }
 
+    public function testRequestRefererCanBeOverridden()
+    {
+        $client = new TestClient();
+        $client->request('GET', 'http://www.example.com/foo/foobar');
+        $client->request('GET', 'bar', [], [], ['HTTP_REFERER' => 'xyz']);
+        $server = $client->getRequest()->getServer();
+        $this->assertEquals('xyz', $server['HTTP_REFERER'], '->request() allows referer to be overridden');
+    }
+
     public function testRequestHistory()
     {
         $client = $this->getBrowser();

Original file line number	Diff line number	Diff line change
`@@ -380,7 +380,7 @@ public function request(string $method, string $uri, array $parameters = [], arr`
`380`	`380`	`$uri = preg_replace('{^'.parse_url($uri, PHP_URL_SCHEME).'}', $server['HTTPS'] ? 'https' : 'http', $uri);`
`381`	`381`	`}`
`382`	`382`
`383`		`- if (!$this->history->isEmpty()) {`
	`383`	`+ if (!isset($server['HTTP_REFERER']) && !$this->history->isEmpty()) {`
`384`	`384`	`$server['HTTP_REFERER'] = $this->history->current()->getUri();`
`385`	`385`	`}`
`386`	`386`