bug #52096 [Notifier] [Brevo] Handle error responses without a message key (stof)

nicolas-grekas · nicolas-grekas · commit 6d216cc4e99c · 2023-10-17T13:44:05.000+02:00
This PR was merged into the 6.4 branch. Discussion ---------- [Notifier] [Brevo] Handle error responses without a message key | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | | License | MIT During their outage yesterday where the endpoint returned errors with status code 500, there was no message key in the json response. This avoids a notice when the key does not exist. Instead, it uses the full response content, as done when the decoding fails. This is the same change than symfony/symfony#52095 but for the new Brevo bridge Commits ------- 517ceaea03 Handle Brevo error responses without a message key
diff --git a/Transport/BrevoApiTransport.php b/Transport/BrevoApiTransport.php
@@ -65,7 +65,7 @@ protected function doSendApi(SentMessage $sentMessage, Email $email, Envelope $e
         }
 
         if (201 !== $statusCode) {
-            throw new HttpTransportException('Unable to send an email: '.$result['message'].sprintf(' (code %d).', $statusCode), $response);
+            throw new HttpTransportException('Unable to send an email: '.($result['message'] ?? $response->getContent(false)).sprintf(' (code %d).', $statusCode), $response);
         }
 
         $sentMessage->setMessageId($result['messageId']);

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@ protected function doSendApi(SentMessage $sentMessage, Email $email, Envelope $e`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`if (201 !== $statusCode) {`
`68`		`- throw new HttpTransportException('Unable to send an email: '.$result['message'].sprintf(' (code %d).', $statusCode), $response);`
	`68`	`+ throw new HttpTransportException('Unable to send an email: '.($result['message'] ?? $response->getContent(false)).sprintf(' (code %d).', $statusCode), $response);`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`$sentMessage->setMessageId($result['messageId']);`