Remove unnecessary empty usages

ostrolucky · ostrolucky · commit 4e3d77e2b442 · 2024-04-01T13:34:39.000+02:00
diff --git a/Transport/Connection.php b/Transport/Connection.php
@@ -156,7 +156,7 @@ public static function fromDsn(#[\SensitiveParameter] string $dsn, array $option
         }
 
         $parsedPath = explode('/', ltrim($params['path'] ?? '/', '/'));
-        if (\count($parsedPath) > 0 && !empty($queueName = end($parsedPath))) {
+        if (\count($parsedPath) > 0 && ($queueName = end($parsedPath))) {
             $configuration['queue_name'] = $queueName;
         }
         $configuration['account'] = 2 === \count($parsedPath) ? $parsedPath[0] : $options['account'] ?? self::DEFAULT_OPTIONS['account'];
@@ -202,7 +202,7 @@ private function getNextMessages(): \Generator
      */
     private function getPendingMessages(): \Generator
     {
-        while (!empty($this->buffer)) {
+        while ($this->buffer) {
             yield array_shift($this->buffer);
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -156,7 +156,7 @@ public static function fromDsn(#[\SensitiveParameter] string $dsn, array $option`
`156`	`156`	`}`
`157`	`157`
`158`	`158`	`$parsedPath = explode('/', ltrim($params['path'] ?? '/', '/'));`
`159`		`- if (\count($parsedPath) > 0 && !empty($queueName = end($parsedPath))) {`
	`159`	`+ if (\count($parsed 8032 Path) > 0 && ($queueName = end($parsedPath))) {`
`160`	`160`	`$configuration['queue_name'] = $queueName;`
`161`	`161`	`}`
`162`	`162`	`$configuration['account'] = 2 === \count($parsedPath) ? $parsedPath[0] : $options['account'] ?? self::DEFAULT_OPTIONS['account'];`
`@@ -202,7 +202,7 @@ private function getNextMessages(): \Generator`
`202`	`202`	`*/`
`203`	`203`	`private function getPendingMessages(): \Generator`
`204`	`204`	`{`
`205`		`- while (!empty($this->buffer)) {`
	`205`	`+ while ($this->buffer) {`
`206`	`206`	`yield array_shift($this->buffer);`
`207`	`207`	`}`
`208`	`208`	`}`