Make AbstractKey an actual abstract class

sybrenstuvel · sybrenstuvel · commit 0b52e7401ce0 · 2023-04-23T15:10:44.000+02:00
Decorate functions that subclassess should implement with
`@abc.abstractmethod`.

This is to fix a mypy error that'll show up when upgrading mypy. That
upgrade will follow shortly -- I just wanted to make sure things keep
working.
diff --git a/rsa/key.py b/rsa/key.py
@@ -31,6 +31,7 @@
 
 """
 
+import abc
 import threading
 import typing
 import warnings
@@ -48,7 +49,7 @@
 T = typing.TypeVar("T", bound="AbstractKey")
 
 
-class AbstractKey:
+class AbstractKey(metaclass=abc.ABCMeta):
     """Abstract superclass for private and public keys."""
 
     __slots__ = ("n", "e", "blindfac", "blindfac_inverse", "mutex")
@@ -65,6 +66,7 @@ def __init__(self, n: int, e: int) -> None:
         self.mutex = threading.Lock()
 
     @classmethod
+    @abc.abstractmethod
     def _load_pkcs1_pem(cls: typing.Type[T], keyfile: bytes) -> T:
         """Loads a key in PKCS#1 PEM format, implement in a subclass.
 
@@ -77,6 +79,7 @@ def _load_pkcs1_pem(cls: typing.Type[T], keyfile: bytes) -> T:
         """
 
     @classmethod
+    @abc.abstractmethod
     def _load_pkcs1_der(cls: typing.Type[T], keyfile: bytes) -> T:
         """Loads a key in PKCS#1 PEM format, implement in a subclass.
 
@@ -88,13 +91,15 @@ def _load_pkcs1_der(cls: typing.Type[T], keyfile: bytes) -> T:
         :rtype: AbstractKey
         """
 
+    @abc.abstractmethod
     def _save_pkcs1_pem(self) -> bytes:
         """Saves the key in PKCS#1 PEM format, implement in a subclass.
 
         :returns: the PEM-encoded key.
         :rtype: bytes
         """
 
+    @abc.abstractmethod
     def _save_pkcs1_der(self) -> bytes:
         """Saves the key in PKCS#1 DER format, implement in a subclass.
 
