[go: up one dir, main page]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to override default keybinding using key chords #1560

Closed
k12teach opened this issue Aug 27, 2024 · 3 comments · Fixed by #1562
Closed

Unable to override default keybinding using key chords #1560

k12teach opened this issue Aug 27, 2024 · 3 comments · Fixed by #1562
Labels
bug Something isn't working

Comments

@k12teach
Copy link

What system are you running Yazi on?

Linux X11

What terminal are you running Yazi in?

kitty

yazi --debug output

Yazi
    Version: 0.3.1 (Arch Linux 2024-08-17)
    Debug  : false
    OS     : linux-x86_64 (unix)

Ya
    Version: 0.3.1 (Arch Linux 2024-08-17)

Emulator
    Emulator.via_env: ("xterm-kitty", "")
    Emulator.via_csi: Ok(Kitty)
    Emulator.detect : Kitty

Adapter
    Adapter.matches: Kitty

Desktop
    XDG_SESSION_TYPE: Some("x11")
    WAYLAND_DISPLAY : None
    DISPLAY         : Some(":0.0")

SSH
    shared.in_ssh_connection: false

WSL
    /proc/sys/fs/binfmt_misc/WSLInterop: false

Variables
    SHELL              : Some("/bin/zsh")
    EDITOR             : Some("emacsclient")
    VISUAL             : None
    YAZI_FILE_ONE      : None
    YAZI_CONFIG_HOME   : None

Text Opener
    default: Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })
    block  : Some(Opener { run: "${EDITOR:-vi} \"$@\"", block: true, orphan: false, desc: "$EDITOR", for_: None, spread: true })

Multiplexers
    TMUX               : false
    tmux version       : No such file or directory (os error 2)
    ZELLIJ_SESSION_NAME: None
    Zellij version     : No such file or directory (os error 2)

Dependencies
    file             : 5.45
    ueberzugpp       : No such file or directory (os error 2)
    ffmpegthumbnailer: 2.2.2
    magick           : 7.1.1-36
    fzf              : 0.54.3
    fd               : 10.1.0
    rg               : 14.1.0
    chafa            : 1.14.2
    zoxide           : 0.9.4
    7z               : 17.05
    7zz              : No such file or directory (os error 2)
    jq               : 1.7.1

Did you try the latest nightly build to see if the problem got fixed?

Yes, and I updated the debug information above (yazi --debug) to the nightly that I tried

Describe the bug

I am attempting to add keychords to expand the goto folder in the keymap.toml file as follows.

[manager]
prepend_keymap = [
  { on = ["g", "d", "d"], run = "cd /data1/downloads", desc = "Go to the downloads directory" },
  { on = ["g", "d", "1"], run = "cd /data1", desc = "Go to /data1" },
  { on = ["g", "d", "2"], run = "cd /data2", desc = "Go to /data2" },
]

This does not unset the default keybinding for "Go to downloads directory" mapped to g d and shows the following mapping on screen.

image

If the entire keymap.toml from https://github.com/sxyazi/yazi/blob/shipped/yazi-config/preset/keymap.toml is used instead of the above with modifications, it works.

Minimal reproducer

Please see the above toml code.

Anything else?

Issue might be similar to #899
@k12teach k12teach added the bug Something isn't working label Aug 27, 2024
@sxyazi sxyazi mentioned this issue Aug 27, 2024
Merged
@sxyazi
Copy link
Owner
sxyazi commented Aug 27, 2024

Please try #1562

@k12teach
Copy link
Author

Yes, it fixes the issue. Thank you.

@github-actions GitHub Actions
Copy link

I'm going to lock this issue because it has been closed for 30 days. ⏳
This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: filter out the which candidates that overlap with longer key chords sxyazi/yazi
2 participants
@sxyazi @k12teach