Modernize hashing

lorentey · web-flow · commit 6591095e5405 · 2018-11-29T19:32:05.000Z
Change syntax nodes to implementing hash(into:) instead of hashValue. The latter was deprecated as a protocol requirement in SE-0206.
diff --git a/Sources/SwiftSyntax/SyntaxNodes.swift.gyb b/Sources/SwiftSyntax/SyntaxNodes.swift.gyb
@@ -145,9 +145,9 @@ public struct ${node.name}: ${base_type}, _SyntaxBase, Hashable {
     return lhs._data === rhs._data
   }
 
-  /// A unique hash value for this node.
-  public var hashValue: Int {
-    return ObjectIdentifier(_data).hashValue
+  /// Feed the essential parts of this node to the supplied hasher.
+  public func hash(into hasher: inout Hasher) {
+    hasher.combine(ObjectIdentifier(_data))
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -145,9 +145,9 @@ public struct ${node.name}: ${base_type}, _SyntaxBase, Hashable {`
`145`	`145`	`return lhs._data === rhs._data`
`146`	`146`	`}`
`147`	`147`
`148`		`- /// A unique hash value for this node.`
`149`		`- public var hashValue: Int {`
`150`		`- return ObjectIdentifier(_data).hashValue`
	`148`	`+ /// Feed the essential parts of this node to the supplied hasher.`
	`149`	`+ public func hash(into hasher: inout Hasher) {`
	`150`	`+ hasher.combine(ObjectIdentifier(_data))`
`151`	`151`	`}`
`152`	`152`	`}`
`153`	`153`