8000 Remove Pull request numbers from previous Changelog entries · swiftlang/swift-syntax@120b589 · GitHub
[go: up one dir, main page]

Skip to content

Commit 120b589

Browse files
committed
Remove Pull request numbers from previous Changelog entries
In new changes we won't know the PR-number up-front and thus can't put it in the changelog until the PR is actually created. Requiring an amend to the PR seems unfortunate, so let's just remove them.
1 parent 3d9b9d5 commit 120b589

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

Changelog.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,15 @@ Note: This is in reverse chronological order, so newer entries are added to the
88

99
Use `is(ExprSyntaxProtocol.self)` etc. instead.
1010

11-
- Property `uniqueIdentifier` removed from syntax nodes and `SyntaxNode` ([#164](https://github.com/apple/swift-syntax/pull/164))
11+
- Property `uniqueIdentifier` removed from syntax nodes and `SyntaxNode`
1212

1313
Use the newly added property `id` or the conformance to `Identifiable` instead.
1414

15-
- Syntax nodes and `SyntaxNode` conform to `Identifiable` ([#164](https://github.com/apple/swift-syntax/pull/164))
15+
- Syntax nodes and `SyntaxNode` conform to `Identifiable`
1616

1717
`Identifiable` conformance has been added to all syntax nodes and the `SyntaxNode` type using `SyntaxIdentifier` as the identifier.
1818

19-
- The `walk` method on syntax nodes has been removed. ([#158](https://github.com/apple/swift-syntax/pull/158))
19+
- The `walk` method on syntax nodes has been removed.
2020

2121
Instead, use the `walk` method on the `SyntaxVisitor`.
2222

@@ -28,7 +28,7 @@ Note: This is in reverse chronological order, so newer entries are added to the
2828
visitor.walk(tree)
2929
```
3030

31-
- `SyntaxVisitor` and `SyntaxAnyVisitor` are a `class` and no longer a `protocol`. ([#158](https://github.com/apple/swift-syntax/pull/158))
31+
- `SyntaxVisitor` and `SyntaxAnyVisitor` are a `class` and no longer a `protocol`.
3232

3333
For performance reasons the `SyntaxVisitor` and `SyntaxAnyVisitor` were migrated from being a protocol to being a class.
3434

@@ -50,7 +50,7 @@ Note: This is in reverse chronological order, so newer entries are added to the
5050
}
5151
```
5252

53-
- A new type `SyntaxEnum` has been introduced ([#155](https://github.com/apple/swift-syntax/pull/155))
53+
- A new type `SyntaxEnum` has been introduced
5454

5555
The new type `SyntaxEnum` allow exhaustive switching over all syntax types. It can be constructed by calling `asSyntaxEnum` on `Syntax`.
5656

@@ -68,7 +68,7 @@ Note: This is in reverse chronological order, so newer entries are added to the
6868

6969
For increased performance, the modelling of the syntax node hierarchy has been switched from being `protocol`-based to being `struct`-based. This includes the following changes:
7070

71-
- The protocols `ExprSyntax`, `DeclSyntax`, `Syntax` etc. have been removed. ([#155](https://github.com/apple/swift-syntax/pull/155))
71+
- The protocols `ExprSyntax`, `DeclSyntax`, `Syntax` etc. have been removed
7272

7373
For passing values of these types around, use the new type erasers `ExprSyntax`, `DeclSyntax`, `Syntax` etc. instead. To add computed properties or functions to all expression nodes, write an extension on `ExprSyntaxProtocol`. To add methods to all syntax nodes, extend `SyntaxProtcol`.
7474

@@ -95,7 +95,7 @@ For increased performance, the modelling of the syntax node hierarchy has been s
9595
```
9696

9797

98-
- Checking a node's type can no longer be performed using the `is` operator. Use the `is(_: SyntaxProtocol)` method on any type eraser instead. ([#155](https://github.com/apple/swift-syntax/pull/155))
98+
- Checking a node's type can no longer be performed using the `is` operator. Use the `is(_: SyntaxProtocol)` method on any type eraser instead.
9999

100100
```swift
101101
// Before
@@ -115,7 +115,7 @@ For increased performance, the modelling of the syntax node hierarchy has been s
115115
```
116116

117117

118-
- Downcasting can no longer be performed using the `as` operator. For downcasting use the `as(_: SyntaxProtocol)` method on any type eraser. ([#155](https://github.com/apple/swift-syntax/pull/155))
118+
- Downcasting can no longer be performed using the `as` operator. For downcasting use the `as(_: SyntaxProtocol)` method on any type eraser.
119119

120120
```swift
121121
// Before
@@ -125,7 +125,7 @@ For increased performance, the modelling of the syntax node hierarchy has been s
125125
exprSyntax.as(IdentifierExprSyntax.self)
126126
```
127127

128-
- Upcasting needs to be performed explicitly. Use the designated initializers for this. ([#155](https://github.com/apple/swift-syntax/pull/155))
128+
- Upcasting needs to be performed explicitly. Use the designated initializers for this.
129129

130130
```swift
131131
// Before

0 commit comments

Comments
 (0)
0