int i should match count, which is a CFIndex #5147
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
reviewed
Dec 11, 2024
Because it fits in a CFIndex and long means more possible optimizations due to unsigned being defined overflow behavior even if it doesn't overflow (thanks LLVM) |
|
Are all of these paths currently exercised? The current migration from swift-corelibs-foundation to swift-foundation means that much of CoreFoundation is unused. |
parkera
approved these changes
May 5, 2025
|
@swift-ci test |
|
I've been trying to delete CF code that is truly unused as we go. Even if I missed some, it seems fine to take this patch to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.