Fixed linter warnings

rbuckton · rbuckton · commit c9f52535f8ef · 2016-02-23T16:36:02.000-08:00
diff --git a/src/compiler/emitter.ts b/src/compiler/emitter.ts
@@ -288,11 +288,6 @@ namespace ts {
     }
 
     export function emitFiles(resolver: EmitResolver, host: EmitHost, targetSourceFile: SourceFile): EmitResult {
-        return printFiles(resolver, host, targetSourceFile);
-    }
-
-    // targetSourceFile is when users only want one file in entire project to be emitted. This is used in compileOnSave feature
-    export function legacyEmitFiles(resolver: EmitResolver, host: EmitHost, targetSourceFile: SourceFile): EmitResult {
         // emit output for the __extends helper function
         const extendsHelper = `
 var __extends = (this && this.__extends) || function (d, b) {
diff --git a/src/compiler/factory.ts b/src/compiler/factory.ts
@@ -743,7 +743,7 @@ namespace ts {
     export function createJsxCreateElement(reactNamespace: string, tagName: Expression, props: Expression, children: Expression[]): LeftHandSideExpression {
         const argumentsList = [tagName];
         if (props) {
-            argumentsList.push(props)
+            argumentsList.push(props);
         }
 
         if (children && children.length > 0) {
diff --git a/src/compiler/transformers/jsx.ts b/src/compiler/transformers/jsx.ts
@@ -40,7 +40,7 @@ namespace ts {
         function transformJsxChildToExpression(node: JsxChild): Expression {
             switch (node.kind) {
                 case SyntaxKind.JsxText:
-                    return visitNonEmptyJsxText(<JsxText>node);
+                    return visitJsxText(<JsxText>node);
 
                 case SyntaxKind.JsxExpression:
                     return visitJsxExpression(<JsxExpression>node);
@@ -69,7 +69,7 @@ namespace ts {
             let objectProperties: Expression;
             if (node.attributes.length === 0) {
                 // When there are no attributes, React wants "null"
-                objectProperties = createLiteral(null);
+                objectProperties = createNull();
             }
             else {
                 // Either emit one big object literal (no spread attribs), or
@@ -124,7 +124,7 @@ namespace ts {
             return createPropertyAssignment(name, expression);
         }
 
-        function visitNonEmptyJsxText(node: JsxText) {
+        function visitJsxText(node: JsxText) {
             const text = getTextToEmit(node);
             if (text !== undefined) {
                 return createLiteral(text);
@@ -155,7 +155,7 @@ namespace ts {
                 const c = text.charCodeAt(i);
                 if (isLineBreak(c)) {
                     if (firstNonWhitespace !== -1 && (lastNonWhitespace - firstNonWhitespace + 1 > 0)) {
-                        let part = text.substr(firstNonWhitespace, lastNonWhitespace - firstNonWhitespace + 1);
+                        const part = text.substr(firstNonWhitespace, lastNonWhitespace - firstNonWhitespace + 1);
                         result = (result ? result + "\" + ' ' + \"" : "") + part;
                     }
                     firstNonWhitespace = -1;
@@ -218,11 +218,6 @@ namespace ts {
             }
         }
 
-        function visitJsxText(node: JsxText) {
-            const text = trimReactWhitespaceAndApplyEntities(node);
-            return createLiteral(text || "");
-        }
-
         function visitJsxExpression(node: JsxExpression) {
             return visitNode(node.expression, visitor, isExpression);
         }

Original file line number	Diff line number	Diff line change
`@@ -743,7 +743,7 @@ namespace ts {`
`743`	`743`	`export function createJsxCreateElement(reactNamespace: string, tagName: Expression, props: Expression, children: Expression[]): LeftHandSideExpression {`
`744`	`744`	`const argumentsList = [tagName];`
`745`	`745`	`if (props) {`
`746`		`- argumentsList.push(props)`
	`746`	`+ argumentsList.push(props);`
`747`	`747`	`}`
`748`	`748`
`749`	`749`	`if (children && children.length > 0) {`