8000 CR feedback · sweshgit/TypeScript@5725fc4 · GitHub
[go: up one dir, main page]

Skip to content

Commit 5725fc4

Browse files
committed
CR feedback
1 parent 61b7100 commit 5725fc4

File tree

9 files changed

+119
-476
lines changed

9 files changed

+119
-476
lines changed

lib/lib.core.d.ts

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1198,22 +1198,6 @@ interface PromiseLike<T> {
11981198
then<TResult>(onfulfilled?: (value: T) => TResult | PromiseLike<TResult>, onrejected?: (reason: any) => void): PromiseLike<TResult>;
11991199
}
12001200

1201-
1202-
declare namespace CommonJS {
1203-
export var require: Require;
1204-
1205-
export var exports: any;
1206-
1207-
interface Exports { }
1208-
interface Module {
1209-
exports: Exports;
1210-
}
1211-
1212-
interface Require {
1213-
(moduleName: string): any;
1214-
}
1215-
}
1216-
12171201
interface ArrayLike<T> {
12181202
length: number;
12191203
[n: number]: T;

lib/lib.core.es6.d.ts

Lines changed: 28 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1198,22 +1198,6 @@ interface PromiseLike<T> {
11981198
then<TResult>(onfulfilled?: (value: T) => TResult | PromiseLike<TResult>, onrejected?: (reason: any) => void): PromiseLike<TResult>;
11991199
}
12001200

1201-
1202-
declare namespace CommonJS {
1203-
export var require: Require;
1204-
1205-
export var exports: any;
1206-
1207-
interface Exports { }
1208-
interface Module {
1209-
exports: Exports;
1210-
}
1211-
1212-
interface Require {
1213-
(moduleName: string): any;
1214-
}
1215-
}
1216-
12171201
interface ArrayLike<T> {
12181202
length: number;
12191203
[n: number]: T;
@@ -3981,7 +3965,34 @@ interface ObjectConstructor {
39813965
* Copy the values of all of the enumerable own properties from one or more source objects to a
39823966
* target object. Returns the target object.
39833967
* @param target The target object to copy to.
3984-
* @param sources One or more source objects to copy properties from.
3968+
* @param source The source object from which to copy properties.
3969+
*/
3970+
assign<T, U>(target: T, source: U): T & U;
3971+
3972+
/**
3973+
* Copy the values of all of the enumerable own properties from one or more source objects to a
3974+
* target object. Returns the target object.
3975+
* @param target The target object to copy to.
3976+
* @param source1 The first source object from which to copy properties.
3977+
* @param source2 The second source object from which to copy properties.
3978+
*/
3979+
assign<T, U, V>(target: T, source1: U, source2: V): T & U & V;
3980+
3981+
/**
3982+
* Copy the values of all of the enumerable own properties from one or more source objects to a
3983+
* target object. Returns the target object.
3984+
* @param target The target object to copy to.
3985+
* @param source1 The first source object from which to copy properties.
3986+
* @param source2 The second source object from which to copy properties.
3987+
* @param source3 The third source object from which to copy properties.
3988+
*/
3989+
assign<T, U, V, W>(target: T, source1: U, source2: V, source3: W): T & U & V & W;
3990+
3991+
/**
3992+
* Copy the values of all of the enumerable own properties from one or more source objects to a
3993+
* target object. Returns the target object.
3994+
* @param target The target object to copy to.
3995+
* @param sources One or more source objects from which to copy properties
39853996
*/
39863997
assign(target: any, ...sources: any[]): any;
39873998

0 commit comments

Comments
 (0)
0