8000 chore: update svelte-ecosystem-ci trigger by dominikg · Pull Request #16315 · sveltejs/svelte · GitHub
[go: up one dir, main page]
Skip to content

chore: update svelte-ecosystem-ci trigger #16315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: update svelte-ecosystem-ci trigger #16315

wants to merge 1 commit into from

Conversation

dominikg
Copy link
Member
@dominikg dominikg commented Jul 7, 2025

compared to vite's trigger, this does not probe pr.pkg.new as we publish all PR commits there anyways.
is this ok or do we have to port that over too?

see https://github.com/vitejs/vite/blob/main/.github/workflows/ecosystem-ci-trigger.yml
and https://github.com/vitejs/vite/blob/38bb268cde15541321f36016e77d61eecb707298/.github/workflows/preview-release.yml#L22

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented Jul 7, 2025

⚠️ No Changeset found

Latest commit: e54b061

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dominikg dominikg marked this pull request as draft July 7, 2025 18:19
@dominikg
Copy link
Member Author
dominikg commented Jul 7, 2025

set to draft because we have to update repo secrets to match this change
8E19

@github-actions GitHub Actions
Copy link
Contributor
github-actions bot commented Jul 7, 2025

Playground

pnpm add https://pkg.pr.new/svelte@16315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dominikg
0