8000 fix: import `untrack` directly from client in `svelte/attachments` by paoloricciuti · Pull Request #15974 · sveltejs/svelte · GitHub
[go: up one dir, main page]
Skip to content

fix: import untrack directly from client in svelte/attachments #15974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2025
Merged

fix: import untrack directly from client in svelte/attachments #15974

merged 1 commit into from
May 21, 2025
+6 −1

Conversation

paoloricciuti
Copy link
Member

Closes #15973

This was causing the circular import...this will technically mean that if you do something silly like calling the utility in the script and then invoking the attachment directly it will bundle the runtime in the server output and we could solve this with a split export for attachments but honestly it seems unnecessary. If you just use it normally it will all be treeshaken away.

<script>
    import { fromAction } from 'svelte/attachments';

    const attachment = fromAction(my_action);

    attachment();
</script>

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot changeset-bot
Copy link
changeset-bot bot commented May 21, 2025

🦋 Changeset detected

Latest commit: 3f7053c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-svelte-15974-svelte.vercel.app/

@github-actions GitHub Actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15974

@Rich-Harris Rich-Harris merged commit 4e72b7d into main May 21, 2025
13 checks passed
@Rich-Harris Rich-Harris deleted the fix-ssr-warn branch May 21, 2025 13:18
@github-actions github-actions bot mentioned this pull request May 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paoloricciuti @Rich-Harris
0